gitlab-org--gitlab-foss/spec
Alfredo Sumaran b4045e997f Merge branch 'group-name-validation' into 'master'
Adds JavaScript validation for group path editing

## What does this MR do?

- Prevents group_edit form submission when special characters are included in the new group name
- Enhances gl_field_errors to support this use case and be more re-usable. 

## Are there points in the code the reviewer needs to double check?

**The implementation of validation is here: 73d997046c**

The rest of the diff for this MR is augmenting gl_field_errors

## Why was this MR needed?

- Currently we allow submission and a 500 error is returned. 

## Screenshots (if relevant)
![2016-10-21_14.11.21](/uploads/2bef5764d3f2429dd0f900661153eef7/2016-10-21_14.11.21.gif)
## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/23564, https://gitlab.com/gitlab-org/gitlab-ce/issues/19756, https://gitlab.com/gitlab-org/gitlab-ce/issues/19736, https://gitlab.com/gitlab-org/gitlab-ce/issues/23922

See merge request !7041
2016-11-03 17:37:00 +00:00
..
bin Add a `--force` option to bin/changelog 2016-11-02 22:15:20 +00:00
config
controllers Implement CreateMembers service to make controller thin 2016-11-01 10:17:04 +02:00
factories
features Merge branch '23713-milestone-dropdown-not-selected' into 'master' 2016-11-02 10:51:44 +00:00
finders
fixtures
helpers
initializers
javascripts Change show-gl-field-errors to gl-show-field-errors 2016-11-02 11:35:21 +01:00
lib Merge branch 'fix/import-export-symlink-vulnerability' into 'security' 2016-11-03 16:04:18 +01:00
mailers
models Use stubs instead of modifying global states 2016-11-03 23:02:19 +08:00
policies Allow owners to fetch source code in CI builds 2016-11-01 09:37:20 +01:00
requests Merge branch 'zj-expose-system-hooks' into 'master' 2016-11-03 16:05:40 +00:00
routing
services Merge branch 'allow-owner-to-run-ci-builds' into 'master' 2016-11-02 09:48:22 +00:00
support Merge branch 'fix/import-export-symlink-vulnerability' into 'security' 2016-11-03 16:04:18 +01:00
tasks/gitlab Add Rake task to create/repair GitLab Shell hooks symlinks 2016-11-01 14:52:59 -05:00
uploaders
views Merge branch '20892-commit-info' into 'master' 2016-10-31 21:29:29 +00:00
workers
factories_spec.rb
rails_helper.rb
rake_helper.rb Add Rake task to create/repair GitLab Shell hooks symlinks 2016-11-01 14:52:59 -05:00
simplecov_env.rb
spec_helper.rb
teaspoon_env.rb