kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/spec/factories
History
Robert Speicher e64594ac44 Merge branch '21983-member-add_user-doesn-t-detect-existing-members-that-have-requested-access' into 'master' 
Resolve "`Member.add_user`doesn't detect existing members that have requested access"

## What does this MR do?

This merge request handle the case when an access requester is added to a group or project (via the members page or the API).

In `Member.add_user`, if an access requester already exists, we simply accept their request (and set the `created_by`, `access_level` and `expires_at` attributes if given).

## Are there points in the code the reviewer needs to double check?

I've taken the opportunity to cleanup the whole `{Group,Project}Member.add_user*` methods since it was quite a mess.

## What are the relevant issue numbers?

Closes #21983

See merge request !6393
2016-10-02 11:42:57 +00:00
..
ci Remove schema annotations completely 2016-09-16 14:37:48 +03:00
abuse_reports.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
appearances.rb Branded login page also in CE 2016-02-26 15:50:51 +01:00
award_emoji.rb Incorportate feedback 2016-06-01 12:10:08 +02:00
boards.rb Add service to create a board list 2016-08-17 12:58:57 -03:00
broadcast_messages.rb TST: Use more accurate time windows so tests do not fail 2016-08-04 14:50:39 -04:00
commit_statuses.rb Pre-create all builds for Pipeline when a trigger is received 2016-08-11 15:22:35 +02:00
commits.rb Refactor and expose only Gitlab::UrlBuilder.build(record) 2016-04-13 16:07:04 +02:00
deploy_keys_projects.rb Move all factory definitions to their own file 2016-03-04 15:26:51 -05:00
deployments.rb Test the CycleAnalytics::Summary model. 2016-09-20 13:23:14 +05:30
emails.rb Remove unused another_email factory 2016-03-06 16:34:43 -05:00
environments.rb Add an URL field to Environments 2016-07-29 13:54:45 +02:00
events.rb Fix broken spec due to last_activity_at updates being throttled 2016-09-19 22:59:15 -07:00
file_uploader.rb Extend specs for GFM uploads rewriter 2016-03-31 09:43:47 +02:00
forked_project_links.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
group_members.rb Add specs for ProjectTeam#fetch_members 2016-09-20 15:18:11 +03:00
groups.rb Improve group visibility level feature 2016-03-18 16:58:04 -03:00
identities.rb Move all factory definitions to their own file 2016-03-04 15:26:51 -05:00
issues.rb Ensure specs on sorting of issues in API are deterministic on MySQL 2016-09-12 15:44:41 +02:00
keys.rb Move all factory definitions to their own file 2016-03-04 15:26:51 -05:00
label_links.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
labels.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
lfs_objects.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
lfs_objects_projects.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
lists.rb Remove label_list factory 2016-08-17 12:58:58 -03:00
merge_requests.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
milestones.rb Updated milestone count helper plus tests 2016-09-07 15:27:14 -05:00
namespaces.rb Move all factory definitions to their own file 2016-03-04 15:26:51 -05:00
notes.rb Optimize discussion notes resolving and unresolving 2016-09-06 12:14:09 -03:00
notification_settings.rb Exclude projects pending delete from notifications 2016-07-07 20:49:17 +01:00
oauth_access_tokens.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
oauth_applications.rb Add spec for deletion of authorized OAuth2 application 2016-04-14 07:24:58 -07:00
personal_access_tokens.rb Allow expiration of personal access tokens. 2016-04-28 22:28:36 +05:30
personal_snippets.rb Simplify the various Snippet factories 2016-03-08 16:40:27 -05:00
project_group_links.rb Bring ProjectGroupLink model and migrations from EE 2016-03-11 17:47:05 +01:00
project_hooks.rb api: expose wiki_page_events project hook field in the API 2016-08-24 10:33:51 -04:00
project_members.rb Allow Member.add_user to handle access requesters 2016-09-28 09:43:00 +02:00
project_snippets.rb Simplify the various Snippet factories 2016-03-08 16:40:27 -05:00
project_wikis.rb Fix wiki tests 2016-04-20 08:25:41 +08:00
projects.rb fix broken repo 500 errors in UI and added relevant specs 2016-09-29 16:58:14 +02:00
protected_branches.rb Fix failing tests relating to backporting ee!581. 2016-08-16 13:42:34 +05:30
releases.rb Remove the annotate gem and delete old annotations 2016-05-09 18:00:28 +02:00
sent_notifications.rb Move all factory definitions to their own file 2016-03-04 15:26:51 -05:00
service_hooks.rb Move all factory definitions to their own file 2016-03-04 15:26:51 -05:00
services.rb Remove unnecessary attribute definitions from Service factory 2016-03-06 16:55:17 -05:00
snippets.rb Simplify the various Snippet factories 2016-03-08 16:40:27 -05:00
spam_logs.rb Move all factory definitions to their own file 2016-03-04 15:26:51 -05:00
system_hooks.rb Move all factory definitions to their own file 2016-03-04 15:26:51 -05:00
todos.rb Add approval required todos 2016-07-12 19:01:09 +01:00
u2f_registrations.rb Add a U2fRegistrations table/model. 2016-06-06 12:50:31 +05:30
user_agent_details.rb Further refactor and syntax fixes. 2016-08-15 17:20:57 -05:00
users.rb Add a U2fRegistrations table/model. 2016-06-06 12:50:31 +05:30
wiki_pages.rb Implement the correct linking behaviour in WikiLinkFilter. 2016-06-09 10:04:15 +05:30