![]() This commit adds the module `FromUnion`, which provides the class method `from_union`. This simplifies the process of selecting data from the result of a UNION, and reduces the likelihood of making mistakes. As a result, instead of this: union = Gitlab::SQL::Union.new([foo, bar]) Foo.from("(#{union.to_sql}) #{Foo.table_name}") We can now write this instead: Foo.from_union([foo, bar]) This commit also includes some changes to make this new setup work properly. For example, a bug in Rails 4 (https://github.com/rails/rails/issues/24193) would break the use of `from("sub-query-here").includes(:relation)` in certain cases. There was also a CI query which appeared to repeat a lot of conditions from an outer query on an inner query, which isn't necessary. Finally, we include a RuboCop cop to ensure developers use this new module, instead of using Gitlab::SQL::Union directly. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/51307 |
||
---|---|---|
.. | ||
admin | ||
autocomplete | ||
concerns | ||
README.md | ||
access_requests_finder.rb | ||
awarded_emoji_finder.rb | ||
branches_finder.rb | ||
clusters_finder.rb | ||
contributed_projects_finder.rb | ||
environments_finder.rb | ||
events_finder.rb | ||
fork_projects_finder.rb | ||
group_descendants_finder.rb | ||
group_finder.rb | ||
group_members_finder.rb | ||
group_projects_finder.rb | ||
groups_finder.rb | ||
issuable_finder.rb | ||
issues_finder.rb | ||
joined_groups_finder.rb | ||
labels_finder.rb | ||
license_template_finder.rb | ||
members_finder.rb | ||
merge_request_target_project_finder.rb | ||
merge_requests_finder.rb | ||
milestones_finder.rb | ||
notes_finder.rb | ||
personal_access_tokens_finder.rb | ||
personal_projects_finder.rb | ||
pipeline_schedules_finder.rb | ||
pipelines_finder.rb | ||
projects_finder.rb | ||
runner_jobs_finder.rb | ||
snippets_finder.rb | ||
tags_finder.rb | ||
template_finder.rb | ||
todos_finder.rb | ||
union_finder.rb | ||
user_finder.rb | ||
user_recent_events_finder.rb | ||
users_finder.rb |
README.md
Finders
This type of classes responsible for collection items based on different conditions. To prevent lookup methods in models like this:
class Project
def issues_for_user_filtered_by(user, filter)
# A lot of logic not related to project model itself
end
end
issues = project.issues_for_user_filtered_by(user, params)
Better use this:
issues = IssuesFinder.new(project, user, filter).execute
It will help keep models thiner.