6f3c490107
This refactors the AutocompleteController according to the guidelines and boundaries discussed in https://gitlab.com/gitlab-org/gitlab-ce/issues/49653. Specifically, ActiveRecord logic is moved to different finders, which are then used in the controller. View logic in turn is moved to presenters, instead of directly using ActiveRecord's "to_json" method. The finder MoveToProjectFinder is also adjusted according to the abstraction guidelines and boundaries, resulting in a much more simple finder. By using finders (and other abstractions) more actively, we can push a lot of logic out of the controller. We also remove the need for various "before_action" hooks, though this could be achieved without using finders as well. The various finders related to AutcompleteController have also been moved into a namespace. This removes the need for calling everything "AutocompleteSmurfFinder", instead you can use "Autocomplete::SmurfFinder".
21 lines
596 B
Ruby
21 lines
596 B
Ruby
# frozen_string_literal: true
|
|
|
|
# Class for retrieving information about emoji awarded _by_ a particular user.
|
|
class AwardedEmojiFinder
|
|
attr_reader :current_user
|
|
|
|
# current_user - The User to generate the data for.
|
|
def initialize(current_user = nil)
|
|
@current_user = current_user
|
|
end
|
|
|
|
def execute
|
|
return [] unless current_user
|
|
|
|
# We want the resulting data set to be an Array containing the emoji names
|
|
# in descending order, based on how often they were awarded.
|
|
AwardEmoji
|
|
.award_counts_for_user(current_user)
|
|
.map { |name, _| { name: name } }
|
|
end
|
|
end
|