3e001d29cc
When used with a Hash, `.keys.include?` is bad because: 1. It performs a O(n) search instead of the efficient `.has_key?` 2. It clones all keys into separate array. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64975
57 lines
1.7 KiB
Ruby
57 lines
1.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class UserPreference < ApplicationRecord
|
|
# We could use enums, but Rails 4 doesn't support multiple
|
|
# enum options with same name for multiple fields, also it creates
|
|
# extra methods that aren't really needed here.
|
|
NOTES_FILTERS = { all_notes: 0, only_comments: 1, only_activity: 2 }.freeze
|
|
|
|
belongs_to :user
|
|
|
|
validates :issue_notes_filter, :merge_request_notes_filter, inclusion: { in: NOTES_FILTERS.values }, presence: true
|
|
|
|
default_value_for :timezone, value: Time.zone.tzinfo.name, allows_nil: false
|
|
default_value_for :time_display_relative, value: true, allows_nil: false
|
|
default_value_for :time_format_in_24h, value: false, allows_nil: false
|
|
|
|
class << self
|
|
def notes_filters
|
|
{
|
|
s_('Notes|Show all activity') => NOTES_FILTERS[:all_notes],
|
|
s_('Notes|Show comments only') => NOTES_FILTERS[:only_comments],
|
|
s_('Notes|Show history only') => NOTES_FILTERS[:only_activity]
|
|
}
|
|
end
|
|
end
|
|
|
|
def set_notes_filter(filter_id, issuable)
|
|
# No need to update the column if the value is already set.
|
|
if filter_id && NOTES_FILTERS.value?(filter_id)
|
|
field = notes_filter_field_for(issuable)
|
|
self[field] = filter_id
|
|
|
|
save if attribute_changed?(field)
|
|
end
|
|
|
|
notes_filter_for(issuable)
|
|
end
|
|
|
|
# Returns the current discussion filter for a given issuable
|
|
# or issuable type.
|
|
def notes_filter_for(resource)
|
|
self[notes_filter_field_for(resource)]
|
|
end
|
|
|
|
private
|
|
|
|
def notes_filter_field_for(resource)
|
|
field_key =
|
|
if resource.is_a?(Issuable)
|
|
resource.model_name.param_key
|
|
else
|
|
resource
|
|
end
|
|
|
|
"#{field_key}_notes_filter"
|
|
end
|
|
end
|