284 lines
9.1 KiB
Ruby
284 lines
9.1 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe API::V3::Files do
|
|
# I have to remove periods from the end of the name
|
|
# This happened when the user's name had a suffix (i.e. "Sr.")
|
|
# This seems to be what git does under the hood. For example, this commit:
|
|
#
|
|
# $ git commit --author='Foo Sr. <foo@example.com>' -m 'Where's my trailing period?'
|
|
#
|
|
# results in this:
|
|
#
|
|
# $ git show --pretty
|
|
# ...
|
|
# Author: Foo Sr <foo@example.com>
|
|
# ...
|
|
|
|
let(:user) { create(:user) }
|
|
let!(:project) { create(:project, :repository, namespace: user.namespace ) }
|
|
let(:guest) { create(:user) { |u| project.add_guest(u) } }
|
|
let(:file_path) { 'files/ruby/popen.rb' }
|
|
let(:params) do
|
|
{
|
|
file_path: file_path,
|
|
ref: 'master'
|
|
}
|
|
end
|
|
let(:author_email) { 'user@example.org' }
|
|
let(:author_name) { 'John Doe' }
|
|
|
|
before { project.team << [user, :developer] }
|
|
|
|
describe "GET /projects/:id/repository/files" do
|
|
let(:route) { "/projects/#{project.id}/repository/files" }
|
|
|
|
shared_examples_for 'repository files' do
|
|
it "returns file info" do
|
|
get v3_api(route, current_user), params
|
|
|
|
expect(response).to have_http_status(200)
|
|
expect(json_response['file_path']).to eq(file_path)
|
|
expect(json_response['file_name']).to eq('popen.rb')
|
|
expect(json_response['last_commit_id']).to eq('570e7b2abdd848b95f2f578043fc23bd6f6fd24d')
|
|
expect(Base64.decode64(json_response['content']).lines.first).to eq("require 'fileutils'\n")
|
|
end
|
|
|
|
context 'when no params are given' do
|
|
it_behaves_like '400 response' do
|
|
let(:request) { get v3_api(route, current_user) }
|
|
end
|
|
end
|
|
|
|
context 'when file_path does not exist' do
|
|
let(:params) do
|
|
{
|
|
file_path: 'app/models/application.rb',
|
|
ref: 'master'
|
|
}
|
|
end
|
|
|
|
it_behaves_like '404 response' do
|
|
let(:request) { get v3_api(route, current_user), params }
|
|
let(:message) { '404 File Not Found' }
|
|
end
|
|
end
|
|
|
|
context 'when repository is disabled' do
|
|
include_context 'disabled repository'
|
|
|
|
it_behaves_like '403 response' do
|
|
let(:request) { get v3_api(route, current_user), params }
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when unauthenticated', 'and project is public' do
|
|
it_behaves_like 'repository files' do
|
|
let(:project) { create(:project, :public, :repository) }
|
|
let(:current_user) { nil }
|
|
end
|
|
end
|
|
|
|
context 'when unauthenticated', 'and project is private' do
|
|
it_behaves_like '404 response' do
|
|
let(:request) { get v3_api(route), params }
|
|
let(:message) { '404 Project Not Found' }
|
|
end
|
|
end
|
|
|
|
context 'when authenticated', 'as a developer' do
|
|
it_behaves_like 'repository files' do
|
|
let(:current_user) { user }
|
|
end
|
|
end
|
|
|
|
context 'when authenticated', 'as a guest' do
|
|
it_behaves_like '403 response' do
|
|
let(:request) { get v3_api(route, guest), params }
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "POST /projects/:id/repository/files" do
|
|
let(:valid_params) do
|
|
{
|
|
file_path: 'newfile.rb',
|
|
branch_name: 'master',
|
|
content: 'puts 8',
|
|
commit_message: 'Added newfile'
|
|
}
|
|
end
|
|
|
|
it "creates a new file in project repo" do
|
|
post v3_api("/projects/#{project.id}/repository/files", user), valid_params
|
|
|
|
expect(response).to have_http_status(201)
|
|
expect(json_response['file_path']).to eq('newfile.rb')
|
|
last_commit = project.repository.commit.raw
|
|
expect(last_commit.author_email).to eq(user.email)
|
|
expect(last_commit.author_name).to eq(user.name)
|
|
end
|
|
|
|
it "returns a 400 bad request if no params given" do
|
|
post v3_api("/projects/#{project.id}/repository/files", user)
|
|
|
|
expect(response).to have_http_status(400)
|
|
end
|
|
|
|
it "returns a 400 if editor fails to create file" do
|
|
allow_any_instance_of(Repository).to receive(:create_file)
|
|
.and_raise(Gitlab::Git::CommitError, 'Cannot create file')
|
|
|
|
post v3_api("/projects/#{project.id}/repository/files", user), valid_params
|
|
|
|
expect(response).to have_http_status(400)
|
|
end
|
|
|
|
context "when specifying an author" do
|
|
it "creates a new file with the specified author" do
|
|
valid_params.merge!(author_email: author_email, author_name: author_name)
|
|
|
|
post v3_api("/projects/#{project.id}/repository/files", user), valid_params
|
|
|
|
expect(response).to have_http_status(201)
|
|
last_commit = project.repository.commit.raw
|
|
expect(last_commit.author_email).to eq(author_email)
|
|
expect(last_commit.author_name).to eq(author_name)
|
|
end
|
|
end
|
|
|
|
context 'when the repo is empty' do
|
|
let!(:project) { create(:project_empty_repo, namespace: user.namespace ) }
|
|
|
|
it "creates a new file in project repo" do
|
|
post v3_api("/projects/#{project.id}/repository/files", user), valid_params
|
|
|
|
expect(response).to have_http_status(201)
|
|
expect(json_response['file_path']).to eq('newfile.rb')
|
|
last_commit = project.repository.commit.raw
|
|
expect(last_commit.author_email).to eq(user.email)
|
|
expect(last_commit.author_name).to eq(user.name)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "PUT /projects/:id/repository/files" do
|
|
let(:valid_params) do
|
|
{
|
|
file_path: file_path,
|
|
branch_name: 'master',
|
|
content: 'puts 8',
|
|
commit_message: 'Changed file'
|
|
}
|
|
end
|
|
|
|
it "updates existing file in project repo" do
|
|
put v3_api("/projects/#{project.id}/repository/files", user), valid_params
|
|
|
|
expect(response).to have_http_status(200)
|
|
expect(json_response['file_path']).to eq(file_path)
|
|
last_commit = project.repository.commit.raw
|
|
expect(last_commit.author_email).to eq(user.email)
|
|
expect(last_commit.author_name).to eq(user.name)
|
|
end
|
|
|
|
it "returns a 400 bad request if no params given" do
|
|
put v3_api("/projects/#{project.id}/repository/files", user)
|
|
|
|
expect(response).to have_http_status(400)
|
|
end
|
|
|
|
context "when specifying an author" do
|
|
it "updates a file with the specified author" do
|
|
valid_params.merge!(author_email: author_email, author_name: author_name, content: "New content")
|
|
|
|
put v3_api("/projects/#{project.id}/repository/files", user), valid_params
|
|
|
|
expect(response).to have_http_status(200)
|
|
last_commit = project.repository.commit.raw
|
|
expect(last_commit.author_email).to eq(author_email)
|
|
expect(last_commit.author_name).to eq(author_name)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "DELETE /projects/:id/repository/files" do
|
|
let(:valid_params) do
|
|
{
|
|
file_path: file_path,
|
|
branch_name: 'master',
|
|
commit_message: 'Changed file'
|
|
}
|
|
end
|
|
|
|
it "deletes existing file in project repo" do
|
|
delete v3_api("/projects/#{project.id}/repository/files", user), valid_params
|
|
|
|
expect(response).to have_http_status(200)
|
|
expect(json_response['file_path']).to eq(file_path)
|
|
last_commit = project.repository.commit.raw
|
|
expect(last_commit.author_email).to eq(user.email)
|
|
expect(last_commit.author_name).to eq(user.name)
|
|
end
|
|
|
|
it "returns a 400 bad request if no params given" do
|
|
delete v3_api("/projects/#{project.id}/repository/files", user)
|
|
|
|
expect(response).to have_http_status(400)
|
|
end
|
|
|
|
it "returns a 400 if fails to delete file" do
|
|
allow_any_instance_of(Repository).to receive(:delete_file).and_raise(Gitlab::Git::CommitError, 'Cannot delete file')
|
|
|
|
delete v3_api("/projects/#{project.id}/repository/files", user), valid_params
|
|
|
|
expect(response).to have_http_status(400)
|
|
end
|
|
|
|
context "when specifying an author" do
|
|
it "removes a file with the specified author" do
|
|
valid_params.merge!(author_email: author_email, author_name: author_name)
|
|
|
|
delete v3_api("/projects/#{project.id}/repository/files", user), valid_params
|
|
|
|
expect(response).to have_http_status(200)
|
|
last_commit = project.repository.commit.raw
|
|
expect(last_commit.author_email).to eq(author_email)
|
|
expect(last_commit.author_name).to eq(author_name)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "POST /projects/:id/repository/files with binary file" do
|
|
let(:file_path) { 'test.bin' }
|
|
let(:put_params) do
|
|
{
|
|
file_path: file_path,
|
|
branch_name: 'master',
|
|
content: 'iVBORw0KGgoAAAANSUhEUgAAAAEAAAABAQMAAAAl21bKAAAAA1BMVEUAAACnej3aAAAAAXRSTlMAQObYZgAAAApJREFUCNdjYAAAAAIAAeIhvDMAAAAASUVORK5CYII=',
|
|
commit_message: 'Binary file with a \n should not be touched',
|
|
encoding: 'base64'
|
|
}
|
|
end
|
|
let(:get_params) do
|
|
{
|
|
file_path: file_path,
|
|
ref: 'master'
|
|
}
|
|
end
|
|
|
|
before do
|
|
post v3_api("/projects/#{project.id}/repository/files", user), put_params
|
|
end
|
|
|
|
it "remains unchanged" do
|
|
get v3_api("/projects/#{project.id}/repository/files", user), get_params
|
|
|
|
expect(response).to have_http_status(200)
|
|
expect(json_response['file_path']).to eq(file_path)
|
|
expect(json_response['file_name']).to eq(file_path)
|
|
expect(json_response['content']).to eq(put_params[:content])
|
|
end
|
|
end
|
|
end
|