dea1171724
Trainee maintainers count as reviewers, but should get more reviews than most reviewers, as they need practice to become a maintainer. This makes them three times as likely to be picked (compared to another reviewer; compared to before, it's roughly twice as likely at the current numbers for each). Also, switch to `Array#sample` because I think it looks nicer.
87 lines
3 KiB
Ruby
87 lines
3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
MESSAGE = <<MARKDOWN
|
|
## Reviewer roulette
|
|
|
|
Changes that require review have been detected! A merge request is normally
|
|
reviewed by both a reviewer and a maintainer in its primary category (e.g.
|
|
~frontend or ~backend), and by a maintainer in all other categories.
|
|
MARKDOWN
|
|
|
|
CATEGORY_TABLE_HEADER = <<MARKDOWN
|
|
|
|
To spread load more evenly across eligible reviewers, Danger has randomly picked
|
|
a candidate for each review slot. Feel free to override this selection if you
|
|
think someone else would be better-suited, or the chosen person is unavailable.
|
|
|
|
Once you've decided who will review this merge request, mention them as you
|
|
normally would! Danger does not (yet?) automatically notify them for you.
|
|
|
|
| Category | Reviewer | Maintainer |
|
|
| -------- | -------- | ---------- |
|
|
MARKDOWN
|
|
|
|
UNKNOWN_FILES_MESSAGE = <<MARKDOWN
|
|
|
|
These files couldn't be categorised, so Danger was unable to suggest a reviewer.
|
|
Please consider creating a merge request to
|
|
[add support](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/lib/gitlab/danger/helper.rb)
|
|
for them.
|
|
MARKDOWN
|
|
|
|
def spin(team, project, category)
|
|
reviewers = team.select { |member| member.reviewer?(project, category) }
|
|
traintainers = team.select { |member| member.traintainer?(project, category) }
|
|
maintainers = team.select { |member| member.maintainer?(project, category) }
|
|
|
|
# TODO: filter out people who are currently not in the office
|
|
# TODO: take CODEOWNERS into account?
|
|
|
|
# Make traintainers have triple the chance to be picked as a reviewer
|
|
reviewer = (reviewers + traintainers + traintainers).sample
|
|
maintainer = maintainers.sample
|
|
|
|
"| #{helper.label_for_category(category)} | #{reviewer&.markdown_name} | #{maintainer&.markdown_name} |"
|
|
end
|
|
|
|
def build_list(items)
|
|
list = items.map { |filename| "* `#{filename}`" }.join("\n")
|
|
|
|
if items.size > 10
|
|
"\n<details>\n\n#{list}\n\n</details>"
|
|
else
|
|
list
|
|
end
|
|
end
|
|
|
|
changes = helper.changes_by_category
|
|
|
|
# Ignore any files that are known but uncategoried. Prompt for any unknown files
|
|
changes.delete(:none)
|
|
categories = changes.keys - [:unknown]
|
|
|
|
# Single codebase MRs are reviewed using a slightly different process, so we
|
|
# disable the review roulette for such MRs.
|
|
# CSS Clean up MRs are reviewed using a slightly different process, so we
|
|
# disable the review roulette for such MRs.
|
|
if changes.any? && !gitlab.mr_labels.include?('single codebase') && !gitlab.mr_labels.include?('CSS cleanup')
|
|
team =
|
|
begin
|
|
helper.project_team
|
|
rescue => err
|
|
warn("Reviewer roulette failed to load team data: #{err.message}")
|
|
[]
|
|
end
|
|
|
|
# Exclude the MR author from the team for selection purposes
|
|
team.delete_if { |teammate| teammate.username == gitlab.mr_author }
|
|
|
|
project = helper.project_name
|
|
unknown = changes.fetch(:unknown, [])
|
|
|
|
rows = categories.map { |category| spin(team, project, category) }
|
|
|
|
markdown(MESSAGE)
|
|
markdown(CATEGORY_TABLE_HEADER + rows.join("\n")) unless rows.empty?
|
|
markdown(UNKNOWN_FILES_MESSAGE + build_list(unknown)) unless unknown.empty?
|
|
end
|