gitlab-org--gitlab-foss/app/services
Stan Hu 377e3670a9 Eliminate unnecessary and duplicate system hook fires
Previously `SystemHookPushWorker` would always be called after a push event,
and this would queue a Sidekiq job regardless of whether any system hooks
needed that event. Moreover, another call inside `Project#execute_hooks` would
also fire system hooks if they existed.

This change both removes the duplicate system hook calls. For installations
without system hooks for push events, this change also can save significant
amount of RAM used by Redis.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/50549
2018-08-21 13:39:02 -07:00
..
application_settings Enable frozen string in apps/services/**/*.rb 2018-07-16 12:36:41 -07:00
applications Enable frozen string in apps/services/**/*.rb 2018-07-16 12:36:41 -07:00
auth Support multiple scopes when using authing container registry scopes 2018-08-01 13:03:16 +02:00
badges Enable frozen string in apps/services/**/*.rb 2018-07-16 12:36:41 -07:00
boards [Backport] View summed weights of issues in board column 2018-07-30 13:44:41 +00:00
chat_names Enable frozen string in apps/services/**/*.rb 2018-07-16 12:36:41 -07:00
ci CE Port of Protected Environments backend 2018-08-10 13:45:14 +00:00
clusters Merge branch 'timeouted' into 'master' 2018-08-01 13:18:52 +00:00
commits Let Commits::TagService return a result hash 2018-08-10 16:45:11 +02:00
concerns Enable frozen string in apps/services/**/*.rb 2018-07-16 12:36:41 -07:00
deploy_keys Enable frozen string in apps/services/**/*.rb 2018-07-16 12:36:41 -07:00
deploy_tokens Enable frozen string in apps/services/**/*.rb 2018-07-16 12:36:41 -07:00
discussions Enable frozen string in apps/services/**/*.rb 2018-07-16 12:36:41 -07:00
emails Enable frozen string in apps/services/**/*.rb 2018-07-16 12:36:41 -07:00
events Enable frozen string in apps/services/**/*.rb 2018-07-16 12:36:41 -07:00
files Enable frozen string in apps/services/**/*.rb 2018-07-16 12:36:41 -07:00
gpg_keys Enable frozen string in apps/services/**/*.rb 2018-07-16 12:36:41 -07:00
groups Fix: Project deletion may not log audit events during group deletion 2018-08-16 13:34:22 +03:00
issuable Enable frozen string in apps/services/**/*.rb 2018-07-16 12:36:41 -07:00
issues Delete todos when users loses target read permissions 2018-07-30 13:29:18 +02:00
keys Enable frozen string in apps/services/**/*.rb 2018-07-16 12:36:41 -07:00
labels Whitelist existing destroy_all offenses 2018-08-16 17:29:37 +02:00
lfs Enable more frozen string in app/services/**/*.rb 2018-07-17 15:19:40 -07:00
mattermost Enable more frozen string in app/services/**/*.rb 2018-07-17 15:19:40 -07:00
members Delete todos when users loses target read permissions 2018-07-30 13:29:18 +02:00
merge_requests Retrieve merge request closing issues from database cache 2018-08-06 11:58:22 -03:00
milestones Whitelist existing destroy_all offenses 2018-08-16 17:29:37 +02:00
notes Rename Commits::UpdateService to Commits::TagService 2018-08-10 16:45:11 +02:00
projects Clean up LFS objects when creating fork relation 2018-08-20 16:39:32 +02:00
prometheus Backports relevant changes made in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5163 to CE 2018-07-25 09:39:39 +01:00
protected_branches Whitelist existing destroy_all offenses 2018-08-16 17:29:37 +02:00
protected_tags Enable more frozen string in app/services/**/*.rb 2018-07-18 14:07:50 -07:00
quick_actions Fix preview of commit tagging 2018-08-10 17:51:34 +02:00
resource_events Resource event model 2018-08-01 08:58:49 +00:00
search Enable more frozen string in app/services/**/*.rb 2018-07-18 14:07:50 -07:00
tags Tag message is frozen so avoid stripping destructively 2018-08-10 19:13:52 +02:00
test_hooks Enable more frozen string in app/services/**/*.rb 2018-07-18 14:07:50 -07:00
todos/destroy Enable frozen string in vestigial app files 2018-08-12 11:07:35 -07:00
users Fix: Project deletion may not log audit events during user deletion 2018-08-17 12:23:27 +03:00
wiki_pages Enable more frozen string in app/services/**/*.rb 2018-07-18 14:07:50 -07:00
access_token_validation_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
after_branch_delete_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
akismet_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
audit_event_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
base_count_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
base_renderer.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
base_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
cohorts_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
compare_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
create_branch_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
create_deployment_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
create_release_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
create_snippet_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
delete_branch_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
delete_merged_branches_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
event_create_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
git_push_service.rb Eliminate unnecessary and duplicate system hook fires 2018-08-21 13:39:02 -07:00
git_tag_push_service.rb Code cleaning in PostReceive services 2018-07-31 14:07:24 +00:00
gravatar_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
ham_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
import_export_clean_up_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
issuable_base_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
merge_request_metrics_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
metrics_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
note_summary.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
notification_recipient_service.rb Allow extensible mention type action for EE 2018-08-14 17:30:40 +08:00
notification_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
preview_markdown_service.rb Implement QuickActions::TargetService 2018-08-10 16:45:11 +02:00
push_event_payload_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
repair_ldap_blocked_user_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
repository_archive_clean_up_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
reset_project_cache_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
search_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
spam_check_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
spam_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
submit_usage_ping_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
system_hooks_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
system_note_service.rb Link to the tag in system note 2018-08-10 16:45:11 +02:00
todo_service.rb Revert "Revert "Merge branch 'ee-5481-epic-todos' into 'master'"" 2018-08-02 10:42:45 +02:00
update_release_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
update_snippet_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
upload_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
user_agent_detail_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
user_project_access_changed_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
validate_new_branch_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
verify_pages_domain_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00
web_hook_service.rb Enable frozen string in apps/uploaders/*.rb 2018-07-16 06:41:59 -07:00