8fbbf41e29
This is allowed for existing instances so we don't end up 76 offenses right away, but for new code one should _only_ use this if they _have_ to remove non database data. Even then it's usually better to do this in a service class as this gives you more control over how to remove the data (e.g. in bulk).
26 lines
755 B
Ruby
26 lines
755 B
Ruby
require_relative '../model_helpers'
|
|
|
|
module RuboCop
|
|
module Cop
|
|
# Cop that prevents the use of `dependent: ...` in ActiveRecord models.
|
|
class ActiveRecordDependent < RuboCop::Cop::Cop
|
|
include ModelHelpers
|
|
|
|
MSG = 'Do not use `dependent: to remove associated data, ' \
|
|
'use foreign keys with cascading deletes instead'.freeze
|
|
|
|
METHOD_NAMES = [:has_many, :has_one, :belongs_to].freeze
|
|
|
|
def on_send(node)
|
|
return unless in_model?(node)
|
|
return unless METHOD_NAMES.include?(node.children[1])
|
|
|
|
node.children.last.each_node(:pair) do |pair|
|
|
key_name = pair.children[0].children[0]
|
|
|
|
add_offense(pair, :expression) if key_name == :dependent
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|