gitlab-org--gitlab-foss/app/controllers
Douwe Maan 4e63411daa Merge branch 'adam-build-missing-services-when-necessary' into 'master'
Defer saving project services to the database if there are no user changes

## What does this MR do?

It defers saving project services to the database as long as it is possible. It creates a project service when creating a project only if this project service has an active template. After that project services are saved on the first edit.

## Are there points in the code the reviewer needs to double check?

- tests that used `build_missing_services` before the change
- number of queries executed

## Why was this MR needed?

Motivation in #22281

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

Fixes #22281

See merge request !6958
2016-11-16 16:27:54 +00:00
..
admin Allow the Sidekiq queues to throttle and the factor by which to throttle them to be configurable 2016-11-10 11:38:11 -06:00
ci Remove Ci::ApplicationController 2016-10-10 16:47:27 +02:00
concerns Fix expanding a collapsed diff when converting a symlink to a regular file 2016-11-10 18:24:12 +01:00
dashboard Limit what label fields we expose on Dashboard::LabelsController#index 2016-10-19 14:58:26 -02:00
explore Precalculate trending projects 2016-10-10 12:27:08 +02:00
groups Require projects before creating milestone 2016-11-10 13:54:37 -05:00
import Merge branch 'security-fix-leaking-namespace-name' into 'security' 2016-10-24 15:49:05 +02:00
oauth Fix endless redirections when accessing user OAuth applications when they are disabled 2016-06-08 05:52:04 -07:00
profiles Address review comments from @smcgivern. 2016-08-18 22:12:02 +05:30
projects Merge branch 'adam-build-missing-services-when-necessary' into 'master' 2016-11-16 16:27:54 +00:00
sherlock
abuse_reports_controller.rb
application_controller.rb Pass @ref along so we know which pipeline to show 2016-10-24 22:26:06 +08:00
autocomplete_controller.rb Fix: Todos Filter Shows All Users 2016-11-04 13:41:14 +02:00
confirmations_controller.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
dashboard_controller.rb Restrict starred projects to viewable ones 2016-05-10 18:13:52 +01:00
emojis_controller.rb
groups_controller.rb Syntax fixes and better tests for helper methods. Updated docs. 2016-09-15 14:10:49 -05:00
health_check_controller.rb Support token header for health check token, and general cleanup of the health_check feature. 2016-05-11 17:27:08 -07:00
help_controller.rb fix error links in help page 2016-11-12 21:45:45 +08:00
invites_controller.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
jwt_controller.rb Merge branch 'unauthenticated-container-registry-access' into 'security' 2016-11-09 12:28:29 +01:00
koding_controller.rb Split Koding admin/user docs 2016-08-22 17:09:15 +03:00
notification_settings_controller.rb merge master into issue_3359_3 2016-06-29 11:04:18 -03:00
omniauth_callbacks_controller.rb Added tests for 2FA check on OAuth request 2016-07-04 11:00:34 -05:00
passwords_controller.rb
profiles_controller.rb implements reset incoming email token on issues modal and account page, 2016-11-07 15:56:18 +00:00
projects_controller.rb Limit autocomplete to currently selected items 2016-11-15 21:41:40 +00:00
registrations_controller.rb Enable Style/SpaceAroundEqualsInParameterDefault cop 2016-08-06 04:03:01 +02:00
root_controller.rb
search_controller.rb Fix broken commits search 2016-11-08 12:03:23 +02:00
sent_notifications_controller.rb Fix initial implementation to actually render the unsubscribe page 2016-09-20 09:52:57 +02:00
sessions_controller.rb Remove provider path, replace with dynamic path. 2016-08-03 11:50:38 -06:00
snippets_controller.rb Added 'Download' button to snippet view 2016-10-11 15:36:59 -04:00
uploads_controller.rb
users_controller.rb Merge branch '23403-fix-events-for-private-project-features' into 'security' 2016-11-09 12:27:41 +01:00