gitlab-org--gitlab-foss/features
Douwe Maan 4dcf107b26 Merge branch '18871-check-improve-how-we-display-access-requesters-in-admin-area' into 'master'
Display group/project access requesters separately in admin

## What does this MR do?

It displays the access requesters in a separate list in group & project members pages.

It also harmonize the members counter UI to use `%span.badge` everywhere (in the admin & non-admin members views).

## Are there points in the code the reviewer needs to double check?

No.

## Why was this MR needed?

To not confuse access requesters with actual members.

## What are the relevant issue numbers?

Closes #18871.

## Screenshots

### Group members

| Before | After |
| --------- | ---- |
| ![group-members-before](/uploads/2f15137e073fd3a63bc2cb7b2217cb6c/group-members-before.png) | ![group-members-after](/uploads/5b643974505cfa57783fa0320d3bf8b2/group-members-after.png) |

### Project members

| Before | After |
| --------- | ---- |
| ![project-members-before](/uploads/9c48dcd3736e42de84061b1201ee0b06/project-members-before.png) | ![project-members-after](/uploads/8e04c92ef0bba3de7e2405618632b27d/project-members-after.png) |

### Admin group members

| Before | After |
| --------- | ---- |
| ![admin-group-members-before](/uploads/7fda8c2c94b697bea6655ba892ba45e7/admin-group-members-before.png) | ![admin-group-members-after](/uploads/ea25717001794f75939c679b80308c3a/admin-group-members-after.png) |

### Admin project members

| Before | After |
| --------- | ---- |
| ![admin-project-members-before](/uploads/ba9d3ec52adbda6bb3d45ad9ac5243d3/admin-project-members-before.png) | ![admin-project-members-after](/uploads/3b889a029a9756e9ed2781b45c4dd9cb/admin-project-members-after.png) |

## Does this MR meet the acceptance criteria?

- [x] No CHANGELOG since this is related to the original "request access" MR.
- [ ] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !4798
2016-06-22 01:17:08 +00:00
..
admin Fix specs 2016-06-21 18:25:44 +02:00
dashboard Fix and remove duplicate specs 2016-06-20 12:36:59 +02:00
explore Fix test 2016-03-04 19:27:02 +01:00
group Updates from last code review. 2016-03-06 23:07:19 -05:00
profile Test changing notification settings per project fron notificaitons page 2016-03-30 10:44:20 +02:00
project Rename Repo -> Repository 2016-06-21 07:54:02 -07:00
snippets fix spinach features to use new button wordings 2015-10-15 17:59:17 +11:00
steps Merge branch '18871-check-improve-how-we-display-access-requesters-in-admin-area' into 'master' 2016-06-22 01:17:08 +00:00
support Enable Knapsack only in CI environment 2016-06-08 11:43:13 +02:00
abuse_report.feature Streamline the "Report button" 2015-09-29 21:47:01 +02:00
groups.feature Remove go to dashboard test suite for group page and get rid of AR warning 2016-05-03 13:04:47 +02:00
invites.feature
search.feature Fixed tests 2016-04-26 09:03:04 +01:00
snippet_search.feature
user.feature Fix specs 2016-03-01 17:42:44 -05:00