53c34c7436
1. Use an advisory lock to guarantee the absence of concurrency in `User.ghost`, to prevent data races from creating more than one ghost, or preventing the creation of ghost users by causing validation errors. 2. Use `update_all` instead of updating issues one-by-one.
51 lines
1.4 KiB
Ruby
51 lines
1.4 KiB
Ruby
module Users
|
|
class DestroyService
|
|
attr_accessor :current_user
|
|
|
|
def initialize(current_user)
|
|
@current_user = current_user
|
|
end
|
|
|
|
def execute(user, options = {})
|
|
unless current_user.admin? || current_user == user
|
|
raise Gitlab::Access::AccessDeniedError, "#{current_user} tried to destroy user #{user}!"
|
|
end
|
|
|
|
if !options[:delete_solo_owned_groups] && user.solo_owned_groups.present?
|
|
user.errors[:base] << 'You must transfer ownership or delete groups before you can remove user'
|
|
return user
|
|
end
|
|
|
|
user.solo_owned_groups.each do |group|
|
|
Groups::DestroyService.new(group, current_user).execute
|
|
end
|
|
|
|
user.personal_projects.each do |project|
|
|
# Skip repository removal because we remove directory with namespace
|
|
# that contain all this repositories
|
|
::Projects::DestroyService.new(project, current_user, skip_repo: true).async_execute
|
|
end
|
|
|
|
move_issues_to_ghost_user(user)
|
|
|
|
# Destroy the namespace after destroying the user since certain methods may depend on the namespace existing
|
|
namespace = user.namespace
|
|
user_data = user.destroy
|
|
namespace.really_destroy!
|
|
|
|
user_data
|
|
end
|
|
|
|
private
|
|
|
|
def move_issues_to_ghost_user(user)
|
|
ghost_user = User.ghost
|
|
|
|
Issue.transaction do
|
|
user.issues.update_all(author_id: ghost_user.id)
|
|
end
|
|
|
|
user.reload
|
|
end
|
|
end
|
|
end
|