6d37fe952b
Fix missing access checks on issue lookup using IssuableFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ⚠️ - Potentially untested 💣 - No test coverage 🚥 - Test coverage of some sort exists (a test failed when error raised) 🚦 - Test coverage of return value (a test failed when nil used) ✅ - Permissions check tested - [x] ✅ app/controllers/projects/branches_controller.rb:39 - `before_action :authorize_push_code!` helpes limit/prevent exploitation. Always checks for reporter access so fine with confidential issues, issues only visible to team, etc. - [x] 🚥 app/models/cycle_analytics/summary.rb:9 [`.count`] - [x] ✅ app/controllers/projects/todos_controller.rb:19 - [x] Potential double render in app/controllers/projects/todos_controller.rb - https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#cedccb227af9bfdf88802767cb58d43c2b977439_24_24 See merge request !2030
62 lines
2.1 KiB
Ruby
62 lines
2.1 KiB
Ruby
class CycleAnalytics
|
|
STAGES = %i[issue plan code test review staging production].freeze
|
|
|
|
def initialize(project, current_user, from:)
|
|
@project = project
|
|
@current_user = current_user
|
|
@from = from
|
|
@fetcher = Gitlab::CycleAnalytics::MetricsFetcher.new(project: project, from: from, branch: nil)
|
|
end
|
|
|
|
def summary
|
|
@summary ||= Summary.new(@project, @current_user, from: @from)
|
|
end
|
|
|
|
def permissions(user:)
|
|
Gitlab::CycleAnalytics::Permissions.get(user: user, project: @project)
|
|
end
|
|
|
|
def issue
|
|
@fetcher.calculate_metric(:issue,
|
|
Issue.arel_table[:created_at],
|
|
[Issue::Metrics.arel_table[:first_associated_with_milestone_at],
|
|
Issue::Metrics.arel_table[:first_added_to_board_at]])
|
|
end
|
|
|
|
def plan
|
|
@fetcher.calculate_metric(:plan,
|
|
[Issue::Metrics.arel_table[:first_associated_with_milestone_at],
|
|
Issue::Metrics.arel_table[:first_added_to_board_at]],
|
|
Issue::Metrics.arel_table[:first_mentioned_in_commit_at])
|
|
end
|
|
|
|
def code
|
|
@fetcher.calculate_metric(:code,
|
|
Issue::Metrics.arel_table[:first_mentioned_in_commit_at],
|
|
MergeRequest.arel_table[:created_at])
|
|
end
|
|
|
|
def test
|
|
@fetcher.calculate_metric(:test,
|
|
MergeRequest::Metrics.arel_table[:latest_build_started_at],
|
|
MergeRequest::Metrics.arel_table[:latest_build_finished_at])
|
|
end
|
|
|
|
def review
|
|
@fetcher.calculate_metric(:review,
|
|
MergeRequest.arel_table[:created_at],
|
|
MergeRequest::Metrics.arel_table[:merged_at])
|
|
end
|
|
|
|
def staging
|
|
@fetcher.calculate_metric(:staging,
|
|
MergeRequest::Metrics.arel_table[:merged_at],
|
|
MergeRequest::Metrics.arel_table[:first_deployed_to_production_at])
|
|
end
|
|
|
|
def production
|
|
@fetcher.calculate_metric(:production,
|
|
Issue.arel_table[:created_at],
|
|
MergeRequest::Metrics.arel_table[:first_deployed_to_production_at])
|
|
end
|
|
end
|