gitlab-org--gitlab-foss/lib/tasks
Rémy Coutable 0876b46024 Merge branch 'memoize_shell_secret_token' into 'master'
Memoize Github::Shell's secret token

## What does this MR do?

`API::Helpers#secret_token` was reading the secret file on every invocation. This MR reads the file in the `gitlab_shell_secret_token.rb` initializer and saves it as a class variable at `Gitlab::Shell.secret_token`

## Are there points in the code the reviewer needs to double check?

 - I'm not sure if the use of `cattr_accessor` is the best approach, or if should be moved into the `class << self` block?
 - Should `API::Helpers#secret_token` be removed in favor of using `Gitlab::Shell.secret_token`?

## Why was this MR needed?

Performance optimization.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/22510

See merge request !6599
2016-10-07 10:35:03 +00:00
..
ci Use `scripts/merge-simplecov` 2016-07-21 12:44:24 +02:00
gitlab Load Github::Shell's secret token from file on initialization instead of every request. 2016-10-06 11:22:37 -04:00
migrate Replace colorize gem with rainbow. 2016-06-03 10:37:09 -06:00
.gitkeep
brakeman.rake Reduce progress bar noise during brakeman run 2016-03-04 22:12:25 +00:00
cache.rake Add markdown cache columns to the database, but don't use them yet 2016-10-07 02:54:25 +01:00
dev.rake Replace GITLAB with GitLab in rake task descriptions 2015-06-23 16:52:40 +02:00
downtime_check.rake Always compare with FETCH_HEAD in downtime_check 2016-08-02 11:57:14 +02:00
flay.rake Set higher flay value to avoid unnecessary refactoring for now 2015-11-17 11:18:01 +01:00
gemojione.rake Upgrade Gemojione from 2.6.1 to 3.0.1. 2016-07-18 10:40:16 -06:00
grape.rake Add grape routing print 2015-11-12 16:26:23 +01:00
haml-lint.rake Improve .haml-lint.yml, simplify the haml_lint task and remove CHANGELOG entry 2016-09-13 18:56:00 +02:00
rubocop.rake Add rubocop-rspec 2016-05-23 15:59:32 -04:00
scss-lint.rake Add SCSS Lint, CSSComb config file, run SCSS Lint in GitLab CI, add documentation for SCSS Style Guide. 2016-03-14 20:33:54 -06:00
services.rake Added service API endpoint to retrieve service parameters 2015-09-10 18:22:57 +02:00
setup.rake Replace GITLAB with GitLab in rake task descriptions 2015-06-23 16:52:40 +02:00
sidekiq.rake Replace GITLAB with GitLab in rake task descriptions 2015-06-23 16:52:40 +02:00
spec.rake Removed benchmark suite and its documentation 2016-03-10 11:15:43 +01:00
spinach.rake Use `File::exist?` instead of `File::exists?` 2016-08-11 13:54:45 +03:00
test.rake Remove unused coveralls 2016-07-21 12:46:49 +02:00