gitlab-org--gitlab-foss/spec/requests/api/issues
Stan Hu 440635015f Fix N+1 Gitaly calls in /api/v4/projects/:id/issues
This is a follow-up from
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31938.

In GitLab 9.0,
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9661 removed the
`subscribed` flag from the API when the user requested a list of issues
or merge requests since calculating this value triggers extensive
Markdown processing.

In GitLab 12.0 via a4fbf39e, we accidentally reintroduced this
performance regression by changing `IssueBasic` to `Issue` in
`entities.rb`. This showed up as a Gitaly N+1 issue since the Markdown
processing would attempt to extract a commit if it detected a regex that
matched a commit.

We restore the prior behavior by once again removing the `subscribed`
flag for the bulk list of issues and merge requests and add a test to
ensure they aren't reintroduced.

Relates to https://gitlab.com/gitlab-org/gitlab-ce/issues/66202
2019-08-23 21:26:50 -07:00
..
get_group_issues_spec.rb Fix Gitaly N+1 calls with listing issues/MRs via API 2019-08-17 20:35:37 -07:00
get_project_issues_spec.rb Fix N+1 Gitaly calls in /api/v4/projects/:id/issues 2019-08-23 21:26:50 -07:00
issues_spec.rb Update sort options for issues list 2019-08-23 11:32:15 +03:00
post_projects_issues_spec.rb
put_projects_issues_spec.rb