Douwe Maan f23b1cb453 Merge branch 'jej-23867-use-mr-finder-instead-of-access-check' into 'security' ... Replace MR access checks with use of MergeRequestsFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ⚠️ - Potentially untested 💣 - No test coverage 🚥 - Test coverage of some sort exists (a test failed when error raised) 🚦 - Test coverage of return value (a test failed when nil used) ✅ - Permissions check tested - [x] 💣 app/finders/notes_finder.rb:17 - [x] ⚠️ app/views/layouts/nav/_project.html.haml:80 [`.count`] - [x] 💣 app/controllers/concerns/creates_commit.rb:84 - [x] 🚥 app/controllers/projects/commits_controller.rb:24 - [x] 🚥 app/controllers/projects/compare_controller.rb:56 - [x] 🚦 app/controllers/projects/discussions_controller.rb:29 - [x] ✅ app/controllers/projects/todos_controller.rb:27 - [x] 🚦 app/models/commit.rb:268 - [x] ✅ lib/gitlab/search_results.rb:71 - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_267_266 Memoize ` merged_merge_request(current_user)` - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_248_247 Expected side effect for `merged_merge_request!`, consider `skip_authorization: true`. - [x] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#d1c10892daedb4d4dd3d4b12b6d071091eea83df_269_269 Scary use of unchecked `merged_merge_request?` See merge request !2033		2016-12-08 21:42:07 -03:00
..
authenticates_with_two_factor.rb	Restrict failed login attempts for users with 2FA	2016-10-04 15:01:38 +01:00
continue_params.rb	Fix denting and spec	2016-03-13 13:44:31 +01:00
creates_commit.rb	Merge branch 'jej-23867-use-mr-finder-instead-of-access-check' into 'security'	2016-12-08 21:42:07 -03:00
cycle_analytics_params.rb	refactored duplicated code in controller, updated JSON array naming and fixed specs	2016-11-17 08:22:57 +01:00
diff_for_path.rb	Fix expanding a collapsed diff when converting a symlink to a regular file	2016-11-10 18:24:12 +01:00
filter_projects.rb	Use compact syntax	2016-04-21 16:02:00 -05:00
global_milestones.rb	Use respond_to instead of a conditional to paginate milestones	2016-03-23 12:02:15 +01:00
issuable_actions.rb	Backport some changes done from Time Tracking feature in EE.	2016-11-18 21:19:04 -05:00
issuable_collections.rb	More aggressively preload on merge request and issue index pages	2016-11-18 14:21:43 +02:00
issues_action.rb	More aggressively preload on merge request and issue index pages	2016-11-18 14:21:43 +02:00
lfs_request.rb	Move LfsHelper to a new LfsRequest concern	2016-11-23 17:28:11 +01:00
membership_actions.rb	Fix a few things after the initial improvment to Members::DestroyService	2016-10-03 16:57:48 +02:00
merge_requests_action.rb	Fix Archived project merge requests add to group's Merge Requests	2016-12-05 18:06:36 +01:00
service_params.rb	Refactor JIRA service to use gem	2016-10-26 15:02:16 -02:00
spammable_actions.rb	Enable Lint/StringConversionInInterpolation cop and autocorrect offenses	2016-10-03 16:09:57 +02:00
toggle_award_emoji.rb	Ensure user is authenticated to create a new snippet	2016-11-28 16:57:49 +01:00
toggle_subscription_action.rb	Use @project as default on ToggleSubscriptionAction concern	2016-11-17 15:10:13 -02:00
workhorse_request.rb	Move LfsHelper to a new LfsRequest concern	2016-11-23 17:28:11 +01:00