gitlab-org--gitlab-foss/lib/gitlab/gitaly_client
Stan Hu db759c5d9c Allow ref name caching CommitService#find_commit
For a given merge request, it's quite common to see duplicate FindCommit
Gitaly requests because the Gitaly CommitService caches the request by
the commit SHA, not by the ref name. However, most of the duplicate
requests use the ref name, so the cache is never actually used in
practice. This leads to unnecessary requests that slow performance.

This commit allows certain callers to bypass the ref name to
OID conversion in the cache. We don't do this by default because it's
possible the tip of the branch changes during the commit, which
would cause the caller to get stale data.

This commit also forces the Ci::Pipeline to use the full ref name
so that caching can work for merge requests.

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/57083
2019-03-27 14:46:39 -05:00
..
attributes_bag.rb Enable even more frozen string in lib/gitlab 2018-11-13 11:42:15 -08:00
blob_service.rb Adds the Rubocop ReturnNil cop 2019-03-06 17:51:56 +02:00
blobs_stitcher.rb Run rubocop -a 2019-03-13 13:42:43 +00:00
cleanup_service.rb Fix repository cleanup with object storage on 2018-12-15 13:50:59 +00:00
commit_service.rb Allow ref name caching CommitService#find_commit 2019-03-27 14:46:39 -05:00
conflict_files_stitcher.rb Enable even more frozen string in lib/gitlab 2018-11-13 11:42:15 -08:00
conflicts_service.rb Enable even more frozen string in lib/gitlab 2018-11-13 11:42:15 -08:00
diff.rb Enable even more frozen string in lib/gitlab 2018-11-13 11:42:15 -08:00
diff_stitcher.rb Enable even more frozen string in lib/gitlab 2018-11-13 11:42:15 -08:00
health_check_service.rb Enable even more frozen string in lib/gitlab 2018-11-13 11:42:15 -08:00
namespace_service.rb Enable even more frozen string in lib/gitlab 2018-11-13 11:42:15 -08:00
notification_service.rb Enable even more frozen string in lib/gitlab 2018-11-13 11:42:15 -08:00
object_pool_service.rb Leave object pools when destroying projects 2018-12-19 13:21:56 +01:00
operation_service.rb Adds the Rubocop ReturnNil cop 2019-03-06 17:51:56 +02:00
queue_enumerator.rb Enable even more frozen string in lib/gitlab 2018-11-13 11:42:15 -08:00
ref_service.rb Backport Gitaly dynamic timeouts from EE 2019-03-12 11:10:40 +01:00
remote_service.rb Remove timeout for GitalyClient remove_remote 2019-03-15 17:15:07 +08:00
repository_service.rb Removing old code path for search_files_by_content 2019-03-01 15:25:30 -08:00
server_service.rb Enable even more frozen string in lib/gitlab 2018-11-13 11:42:15 -08:00
storage_service.rb Enable even more frozen string in lib/gitlab 2018-11-13 11:42:15 -08:00
storage_settings.rb Bring back Rugged implementation of find_commit 2019-03-01 08:45:51 -08:00
util.rb Rename gl_project_name -> gl_project_path 2019-02-05 21:33:10 -08:00
wiki_file.rb Enable even more frozen string in lib/gitlab 2018-11-13 11:42:15 -08:00
wiki_page.rb Enable even more frozen string in lib/gitlab 2018-11-13 11:42:15 -08:00
wiki_service.rb Enable even more frozen string in lib/gitlab 2018-11-13 11:42:15 -08:00