ebb284c0dc
As discussed in https://github.com/mbleigh/acts-as-taggable-on/issues/91, we can avoid N+1 queries if we use `tags` instead of `tag_list`. Seen while reviewing https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19740.
102 lines
2.4 KiB
Ruby
102 lines
2.4 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Admin::RunnersController do
|
|
let!(:runner) { create(:ci_runner) }
|
|
|
|
before do
|
|
sign_in(create(:admin))
|
|
end
|
|
|
|
describe '#index' do
|
|
render_views
|
|
|
|
it 'lists all runners' do
|
|
get :index
|
|
|
|
expect(response).to have_gitlab_http_status(200)
|
|
end
|
|
|
|
it 'avoids N+1 queries', :request_store do
|
|
get :index
|
|
|
|
control_count = ActiveRecord::QueryRecorder.new { get :index }.count
|
|
|
|
create(:ci_runner, :tagged_only)
|
|
|
|
# There is still an N+1 query for `runner.builds.count`
|
|
expect { get :index }.not_to exceed_query_limit(control_count + 1)
|
|
|
|
expect(response).to have_gitlab_http_status(200)
|
|
expect(response.body).to have_content('tag1')
|
|
expect(response.body).to have_content('tag2')
|
|
end
|
|
end
|
|
|
|
describe '#show' do
|
|
it 'shows a particular runner' do
|
|
get :show, params: { id: runner.id }
|
|
|
|
expect(response).to have_gitlab_http_status(200)
|
|
end
|
|
|
|
it 'shows 404 for unknown runner' do
|
|
get :show, params: { id: 0 }
|
|
|
|
expect(response).to have_gitlab_http_status(404)
|
|
end
|
|
end
|
|
|
|
describe '#update' do
|
|
it 'updates the runner and ticks the queue' do
|
|
new_desc = runner.description.swapcase
|
|
|
|
expect do
|
|
post :update, params: { id: runner.id, runner: { description: new_desc } }
|
|
end.to change { runner.ensure_runner_queue_value }
|
|
|
|
runner.reload
|
|
|
|
expect(response).to have_gitlab_http_status(302)
|
|
expect(runner.description).to eq(new_desc)
|
|
end
|
|
end
|
|
|
|
describe '#destroy' do
|
|
it 'destroys the runner' do
|
|
delete :destroy, params: { id: runner.id }
|
|
|
|
expect(response).to have_gitlab_http_status(302)
|
|
expect(Ci::Runner.find_by(id: runner.id)).to be_nil
|
|
end
|
|
end
|
|
|
|
describe '#resume' do
|
|
it 'marks the runner as active and ticks the queue' do
|
|
runner.update(active: false)
|
|
|
|
expect do
|
|
post :resume, params: { id: runner.id }
|
|
end.to change { runner.ensure_runner_queue_value }
|
|
|
|
runner.reload
|
|
|
|
expect(response).to have_gitlab_http_status(302)
|
|
expect(runner.active).to eq(true)
|
|
end
|
|
end
|
|
|
|
describe '#pause' do
|
|
it 'marks the runner as inactive and ticks the queue' do
|
|
runner.update(active: true)
|
|
|
|
expect do
|
|
post :pause, params: { id: runner.id }
|
|
end.to change { runner.ensure_runner_queue_value }
|
|
|
|
runner.reload
|
|
|
|
expect(response).to have_gitlab_http_status(302)
|
|
expect(runner.active).to eq(false)
|
|
end
|
|
end
|
|
end
|