gitlab-org--gitlab-foss/spec/lib
Sean McGivern 5883ce95ef current_application_settings belongs on Gitlab::CurrentSettings
The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.
2017-08-31 13:38:33 +01:00
..
api/helpers Total Pages should be at least one 2017-08-17 21:47:01 +02:00
banzai Support references to group milestones 2017-08-07 11:55:00 +01:00
bitbucket Enable the Layout/SpaceBeforeBlockBraces cop 2017-08-09 11:52:22 +02:00
ci Fix rubocop offense in YAML processor specs 2017-08-26 10:57:43 +02:00
constraints Change all :empty_project to :project 2017-08-02 17:47:31 -04:00
container_registry Change all :empty_project to :project 2017-08-02 17:47:31 -04:00
gitlab current_application_settings belongs on Gitlab::CurrentSettings 2017-08-31 13:38:33 +01:00
json_web_token Enable the Layout/SpaceBeforeBlockBraces cop 2017-08-09 11:52:22 +02:00
mattermost Fix Mattermost integration 2017-08-04 12:22:10 +03:00
microsoft_teams
rspec_flaky Use a new RspecFlakyListener to detect flaky specs 2017-08-11 14:55:10 +02:00
system_check Enable the Layout/SpaceBeforeBlockBraces cop 2017-08-09 11:52:22 +02:00
additional_email_headers_interceptor_spec.rb
after_commit_queue_spec.rb Backports EE mirror stuck handling feature (https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2628) to CE 2017-08-17 13:38:05 +01:00
disable_email_interceptor_spec.rb Use described_class when possible 2017-07-27 14:31:53 +02:00
event_filter_spec.rb Migrate events into a new format 2017-08-10 17:45:44 +02:00
expand_variables_spec.rb
extracts_path_spec.rb Enable the Layout/SpaceBeforeBlockBraces cop 2017-08-09 11:52:22 +02:00
feature_spec.rb
file_size_validator_spec.rb Whitelist or fix additional Gitlab/PublicSend cop violations 2017-08-14 12:14:11 -04:00
gitlab_spec.rb
repository_cache_spec.rb Change all :empty_project to :project 2017-08-02 17:47:31 -04:00
system_check_spec.rb Use described_class when possible 2017-07-27 14:31:53 +02:00