6ef87a2083
Having two states that essentially mean the same thing is very much like
having a boolean "true" and boolean "mostly-true": it's rather silly.
This commit merges the "reopened" state into the "opened" state while
taking care of system notes still showing messages along the lines of
"Alice reopened this issue".
A big benefit from having only two states (opened and closed) is that
indexing and querying becomes simpler and more performant. For example,
to get all the opened queries we no longer have to query both states:
SELECT *
FROM issues
WHERE project_id = 2
AND state IN ('opened', 'reopened');
Instead we can query a single state directly, which can be much faster:
SELECT *
FROM issues
WHERE project_id = 2
AND state = 'opened';
Further, only having two states makes indexing easier as we will only
ever filter (and thus scan an index) using a single value. Partial
indexes could help but aren't supported on MySQL, complicating the
development process and not being helpful for MySQL.
62 lines
1.7 KiB
Ruby
62 lines
1.7 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe MergeRequests::ReopenService do
|
|
let(:user) { create(:user) }
|
|
let(:user2) { create(:user) }
|
|
let(:guest) { create(:user) }
|
|
let(:merge_request) { create(:merge_request, :closed, assignee: user2) }
|
|
let(:project) { merge_request.project }
|
|
|
|
before do
|
|
project.team << [user, :master]
|
|
project.team << [user2, :developer]
|
|
project.team << [guest, :guest]
|
|
end
|
|
|
|
describe '#execute' do
|
|
it_behaves_like 'cache counters invalidator'
|
|
|
|
context 'valid params' do
|
|
let(:service) { described_class.new(project, user, {}) }
|
|
|
|
before do
|
|
allow(service).to receive(:execute_hooks)
|
|
|
|
perform_enqueued_jobs do
|
|
service.execute(merge_request)
|
|
end
|
|
end
|
|
|
|
it { expect(merge_request).to be_valid }
|
|
it { expect(merge_request).to be_opened }
|
|
|
|
it 'executes hooks with reopen action' do
|
|
expect(service).to have_received(:execute_hooks)
|
|
.with(merge_request, 'reopen')
|
|
end
|
|
|
|
it 'sends email to user2 about reopen of merge_request' do
|
|
email = ActionMailer::Base.deliveries.last
|
|
expect(email.to.first).to eq(user2.email)
|
|
expect(email.subject).to include(merge_request.title)
|
|
end
|
|
|
|
it 'creates system note about merge_request reopen' do
|
|
note = merge_request.notes.last
|
|
expect(note.note).to include 'reopened'
|
|
end
|
|
end
|
|
|
|
context 'current user is not authorized to reopen merge request' do
|
|
before do
|
|
perform_enqueued_jobs do
|
|
@merge_request = described_class.new(project, guest).execute(merge_request)
|
|
end
|
|
end
|
|
|
|
it 'does not reopen the merge request' do
|
|
expect(@merge_request).to be_closed
|
|
end
|
|
end
|
|
end
|
|
end
|