57b96eb6db
This ensures the open issues/MR count caches are refreshed properly when creating new issues or MRs. This MR also includes a change to the cache keys to ensure all caches are rebuilt on the fly. This particular problem was not caught in the test suite due to a null cache being used, resulting in all calls that would use a cache using the underlying data directly. In production the code would fail because a newly saved record returns an empty hash in #changes meaning checks such as `state_changed? || confidential_changed?` would return false for new rows, thus never updating the counters. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/38061
23 lines
860 B
Ruby
23 lines
860 B
Ruby
module MergeRequests
|
|
class CloseService < MergeRequests::BaseService
|
|
def execute(merge_request, commit = nil)
|
|
return merge_request unless can?(current_user, :update_merge_request, merge_request)
|
|
|
|
# If we close MergeRequest we want to ignore validation
|
|
# so we can close broken one (Ex. fork project removed)
|
|
merge_request.allow_broken = true
|
|
|
|
if merge_request.close
|
|
event_service.close_mr(merge_request, current_user)
|
|
create_note(merge_request)
|
|
notification_service.close_mr(merge_request, current_user)
|
|
todo_service.close_merge_request(merge_request, current_user)
|
|
execute_hooks(merge_request, 'close')
|
|
invalidate_cache_counts(merge_request, users: merge_request.assignees)
|
|
merge_request.update_project_counter_caches
|
|
end
|
|
|
|
merge_request
|
|
end
|
|
end
|
|
end
|