259 lines
8.1 KiB
Ruby
259 lines
8.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe 'Merge request > User sees pipelines', :js do
|
|
describe 'pipeline tab' do
|
|
let(:merge_request) { create(:merge_request) }
|
|
let(:project) { merge_request.target_project }
|
|
let(:user) { project.creator }
|
|
|
|
before do
|
|
project.add_maintainer(user)
|
|
sign_in(user)
|
|
end
|
|
|
|
context 'with pipelines' do
|
|
let!(:pipeline) do
|
|
create(:ci_empty_pipeline,
|
|
project: merge_request.source_project,
|
|
ref: merge_request.source_branch,
|
|
sha: merge_request.diff_head_sha)
|
|
end
|
|
|
|
before do
|
|
merge_request.update_attribute(:head_pipeline_id, pipeline.id)
|
|
end
|
|
|
|
it 'user visits merge request pipelines tab' do
|
|
visit project_merge_request_path(project, merge_request)
|
|
|
|
expect(page.find('.ci-widget')).to have_content('pending')
|
|
|
|
page.within('.merge-request-tabs') do
|
|
click_link('Pipelines')
|
|
end
|
|
wait_for_requests
|
|
|
|
expect(page).to have_selector('.stage-cell')
|
|
end
|
|
|
|
context 'with a detached merge request pipeline' do
|
|
let(:merge_request) { create(:merge_request, :with_detached_merge_request_pipeline) }
|
|
|
|
it 'displays the Run Pipeline button' do
|
|
visit project_merge_request_path(project, merge_request)
|
|
|
|
page.within('.merge-request-tabs') do
|
|
click_link('Pipelines')
|
|
end
|
|
|
|
wait_for_requests
|
|
|
|
expect(page.find('[data-testid="run_pipeline_button"]')).to have_text('Run Pipeline')
|
|
end
|
|
end
|
|
|
|
context 'with a merged results pipeline' do
|
|
let(:merge_request) { create(:merge_request, :with_merge_request_pipeline) }
|
|
|
|
it 'displays the Run Pipeline button' do
|
|
visit project_merge_request_path(project, merge_request)
|
|
|
|
page.within('.merge-request-tabs') do
|
|
click_link('Pipelines')
|
|
end
|
|
|
|
wait_for_requests
|
|
|
|
expect(page.find('[data-testid="run_pipeline_button"]')).to have_text('Run Pipeline')
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'without pipelines' do
|
|
before do
|
|
visit project_merge_request_path(project, merge_request)
|
|
end
|
|
|
|
it 'user visits merge request page' do
|
|
page.within('.merge-request-tabs') do
|
|
expect(page).to have_no_link('Pipelines')
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'fork MRs in parent project', :sidekiq_inline do
|
|
include ProjectForksHelper
|
|
|
|
let_it_be(:parent_project) { create(:project, :public, :repository) }
|
|
let_it_be(:forked_project) { fork_project(parent_project, developer_in_fork, repository: true, target_project: create(:project, :public, :repository)) }
|
|
let_it_be(:developer_in_parent) { create(:user) }
|
|
let_it_be(:developer_in_fork) { create(:user) }
|
|
let_it_be(:reporter_in_parent_and_developer_in_fork) { create(:user) }
|
|
|
|
let(:merge_request) do
|
|
create(:merge_request, :with_detached_merge_request_pipeline,
|
|
source_project: forked_project, source_branch: 'feature',
|
|
target_project: parent_project, target_branch: 'master')
|
|
end
|
|
|
|
let(:config) do
|
|
{ test: { script: 'test', rules: [{ if: '$CI_MERGE_REQUEST_ID' }] } }
|
|
end
|
|
|
|
before_all do
|
|
parent_project.add_developer(developer_in_parent)
|
|
parent_project.add_reporter(reporter_in_parent_and_developer_in_fork)
|
|
forked_project.add_developer(developer_in_fork)
|
|
forked_project.add_developer(reporter_in_parent_and_developer_in_fork)
|
|
end
|
|
|
|
before do
|
|
stub_ci_pipeline_yaml_file(YAML.dump(config))
|
|
sign_in(actor)
|
|
end
|
|
|
|
after do
|
|
parent_project.all_pipelines.delete_all
|
|
forked_project.all_pipelines.delete_all
|
|
end
|
|
|
|
context 'when actor is a developer in parent project' do
|
|
let(:actor) { developer_in_parent }
|
|
|
|
before do
|
|
stub_feature_flags(ci_disallow_to_create_merge_request_pipelines_in_target_project: false)
|
|
end
|
|
|
|
it 'creates a pipeline in the parent project when user proceeds with the warning' do
|
|
visit project_merge_request_path(parent_project, merge_request)
|
|
|
|
create_merge_request_pipeline
|
|
act_on_security_warning(action: 'Run Pipeline')
|
|
|
|
check_pipeline(expected_project: parent_project)
|
|
check_head_pipeline(expected_project: parent_project)
|
|
end
|
|
|
|
it 'does not create a pipeline in the parent project when user cancels the action' do
|
|
visit project_merge_request_path(parent_project, merge_request)
|
|
|
|
create_merge_request_pipeline
|
|
act_on_security_warning(action: 'Cancel')
|
|
|
|
check_no_pipelines
|
|
end
|
|
end
|
|
|
|
context 'when actor is a developer in fork project' do
|
|
let(:actor) { developer_in_fork }
|
|
|
|
it 'creates a pipeline in the fork project' do
|
|
visit project_merge_request_path(parent_project, merge_request)
|
|
|
|
create_merge_request_pipeline
|
|
|
|
check_pipeline(expected_project: forked_project)
|
|
check_head_pipeline(expected_project: forked_project)
|
|
end
|
|
end
|
|
|
|
context 'when actor is a reporter in parent project and a developer in fork project' do
|
|
let(:actor) { reporter_in_parent_and_developer_in_fork }
|
|
|
|
it 'creates a pipeline in the fork project' do
|
|
visit project_merge_request_path(parent_project, merge_request)
|
|
|
|
create_merge_request_pipeline
|
|
|
|
check_pipeline(expected_project: forked_project)
|
|
check_head_pipeline(expected_project: forked_project)
|
|
end
|
|
end
|
|
|
|
def create_merge_request_pipeline
|
|
page.within('.merge-request-tabs') { click_link('Pipelines') }
|
|
click_button('Run Pipeline')
|
|
end
|
|
|
|
def check_pipeline(expected_project:)
|
|
page.within('.ci-table') do
|
|
expect(page).to have_selector('.commit', count: 2)
|
|
|
|
page.within(first('.commit')) do
|
|
page.within('.pipeline-tags') do
|
|
expect(page.find('.js-pipeline-url-link')[:href]).to include(expected_project.full_path)
|
|
expect(page).to have_content('detached')
|
|
end
|
|
page.within('.pipeline-triggerer') do
|
|
expect(page).to have_link(href: user_path(actor))
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
def check_head_pipeline(expected_project:)
|
|
page.within('.merge-request-tabs') { click_link('Overview') }
|
|
|
|
page.within('.ci-widget-content') do
|
|
expect(page.find('.pipeline-id')[:href]).to include(expected_project.full_path)
|
|
end
|
|
end
|
|
|
|
def act_on_security_warning(action:)
|
|
page.within('#create-pipeline-for-fork-merge-request-modal') do
|
|
expect(page).to have_content('Are you sure you want to run this pipeline?')
|
|
click_button(action)
|
|
end
|
|
end
|
|
|
|
def check_no_pipelines
|
|
page.within('.ci-table') do
|
|
expect(page).to have_selector('.commit', count: 1)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'race condition' do
|
|
let(:project) { create(:project, :repository) }
|
|
let(:user) { create(:user) }
|
|
let(:build_push_data) { { ref: 'feature', checkout_sha: TestEnv::BRANCH_SHA['feature'] } }
|
|
|
|
let(:merge_request_params) do
|
|
{ "source_branch" => "feature", "source_project_id" => project.id,
|
|
"target_branch" => "master", "target_project_id" => project.id, "title" => "A" }
|
|
end
|
|
|
|
before do
|
|
project.add_maintainer(user)
|
|
sign_in user
|
|
end
|
|
|
|
context 'when pipeline and merge request were created simultaneously' do
|
|
before do
|
|
stub_ci_pipeline_to_return_yaml_file
|
|
|
|
threads = []
|
|
|
|
threads << Thread.new do
|
|
@merge_request = MergeRequests::CreateService.new(project, user, merge_request_params).execute
|
|
end
|
|
|
|
threads << Thread.new do
|
|
@pipeline = Ci::CreatePipelineService.new(project, user, build_push_data).execute(:push)
|
|
end
|
|
|
|
threads.each { |thr| thr.join }
|
|
end
|
|
|
|
it 'user sees pipeline in merge request widget', :sidekiq_might_not_need_inline do
|
|
visit project_merge_request_path(project, @merge_request)
|
|
|
|
expect(page.find(".ci-widget")).to have_content(TestEnv::BRANCH_SHA['feature'])
|
|
expect(page.find(".ci-widget")).to have_content("##{@pipeline.id}")
|
|
end
|
|
end
|
|
end
|
|
end
|