5b0954759c
Fix static-snalysis Move the precedence of group secure variable before project secure variable. Allow project_id to be null. Separate Ci::VariableProject and Ci::VariableGroup Add the forgotton files Add migration file to update type of ci_variables Fix form_for fpr VariableProject Fix test Change the table structure according to the yorik advice Add necessary migration files. Remove unnecessary migration spec. Revert safe_model_attributes.yml Fix models Fix spec Avoid self.variable. Use becomes for correct routing. Use unique index on group_id and key Add null: false for t.timestamps Fix schema version Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable Rename the rest of them Add the rest of files Basic BE change Fix static-snalysis Move the precedence of group secure variable before project secure variable. Allow project_id to be null. Separate Ci::VariableProject and Ci::VariableGroup Add the forgotton files Add migration file to update type of ci_variables Fix form_for fpr VariableProject Fix test Change the table structure according to the yorik advice Add necessary migration files. Remove unnecessary migration spec. Revert safe_model_attributes.yml Fix models Fix spec Avoid self.variable. Use becomes for correct routing. Use unique index on group_id and key Add null: false for t.timestamps Fix schema version Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable Rename the rest of them Add the rest of files Implement CURD Rename codes related to VariableGroup and VariableProject FE part Remove unneccesary changes Make Fe code up-to-date Add protected flag to migration file Protected group variables essential package Update schema Improve doc Fix logic and spec for models Fix logic and spec for controllers Fix logic and spec for views(pre feature) Add feature spec Fixed bugs. placeholder. reveal button. doc. Add changelog Remove unnecessary comment godfat nice catches Improve secret_variables_for arctecture Fix spec Fix StaticAnlysys & path_regex spec Revert "Improve secret_variables_for arctecture" This reverts commit c3216ca212322ecf6ca534cb12ce75811a4e77f1. Use ayufan suggestion for secret_variables_for Use find instead of find_by Fix spec message for variable is invalid Fix spec remove variable.group_id = group.id godffat spec nitpicks Use include Gitlab::Routing.url_helpers for presenter spec
145 lines
3.9 KiB
Ruby
145 lines
3.9 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe 'Project variables', js: true do
|
|
let(:user) { create(:user) }
|
|
let(:project) { create(:empty_project) }
|
|
let(:variable) { create(:ci_variable, key: 'test_key', value: 'test value') }
|
|
|
|
before do
|
|
gitlab_sign_in(user)
|
|
project.team << [user, :master]
|
|
project.variables << variable
|
|
|
|
visit project_settings_ci_cd_path(project)
|
|
end
|
|
|
|
it 'shows list of variables' do
|
|
page.within('.variables-table') do
|
|
expect(page).to have_content(variable.key)
|
|
end
|
|
end
|
|
|
|
it 'adds new secret variable' do
|
|
fill_in('variable_key', with: 'key')
|
|
fill_in('variable_value', with: 'key value')
|
|
click_button('Add new variable')
|
|
|
|
expect(page).to have_content('Variables were successfully updated.')
|
|
page.within('.variables-table') do
|
|
expect(page).to have_content('key')
|
|
expect(page).to have_content('No')
|
|
end
|
|
end
|
|
|
|
it 'adds empty variable' do
|
|
fill_in('variable_key', with: 'new_key')
|
|
fill_in('variable_value', with: '')
|
|
click_button('Add new variable')
|
|
|
|
expect(page).to have_content('Variables were successfully updated.')
|
|
page.within('.variables-table') do
|
|
expect(page).to have_content('new_key')
|
|
end
|
|
end
|
|
|
|
it 'adds new protected variable' do
|
|
fill_in('variable_key', with: 'key')
|
|
fill_in('variable_value', with: 'value')
|
|
check('Protected')
|
|
click_button('Add new variable')
|
|
|
|
expect(page).to have_content('Variables were successfully updated.')
|
|
page.within('.variables-table') do
|
|
expect(page).to have_content('key')
|
|
expect(page).to have_content('Yes')
|
|
end
|
|
end
|
|
|
|
it 'reveals and hides new variable' do
|
|
fill_in('variable_key', with: 'key')
|
|
fill_in('variable_value', with: 'key value')
|
|
click_button('Add new variable')
|
|
|
|
page.within('.variables-table') do
|
|
expect(page).to have_content('key')
|
|
expect(page).to have_content('******')
|
|
end
|
|
|
|
click_button('Reveal Values')
|
|
|
|
page.within('.variables-table') do
|
|
expect(page).to have_content('key')
|
|
expect(page).to have_content('key value')
|
|
end
|
|
|
|
click_button('Hide Values')
|
|
|
|
page.within('.variables-table') do
|
|
expect(page).to have_content('key')
|
|
expect(page).to have_content('******')
|
|
end
|
|
end
|
|
|
|
it 'deletes variable' do
|
|
page.within('.variables-table') do
|
|
click_on 'Remove'
|
|
end
|
|
|
|
expect(page).not_to have_selector('variables-table')
|
|
end
|
|
|
|
it 'edits variable' do
|
|
page.within('.variables-table') do
|
|
click_on 'Update'
|
|
end
|
|
|
|
expect(page).to have_content('Update variable')
|
|
fill_in('variable_key', with: 'key')
|
|
fill_in('variable_value', with: 'key value')
|
|
click_button('Save variable')
|
|
|
|
expect(page).to have_content('Variable was successfully updated.')
|
|
expect(project.variables(true).first.value).to eq('key value')
|
|
end
|
|
|
|
it 'edits variable with empty value' do
|
|
page.within('.variables-table') do
|
|
click_on 'Update'
|
|
end
|
|
|
|
expect(page).to have_content('Update variable')
|
|
fill_in('variable_value', with: '')
|
|
click_button('Save variable')
|
|
|
|
expect(page).to have_content('Variable was successfully updated.')
|
|
expect(project.variables(true).first.value).to eq('')
|
|
end
|
|
|
|
it 'edits variable to be protected' do
|
|
page.within('.variables-table') do
|
|
click_on 'Update'
|
|
end
|
|
|
|
expect(page).to have_content('Update variable')
|
|
check('Protected')
|
|
click_button('Save variable')
|
|
|
|
expect(page).to have_content('Variable was successfully updated.')
|
|
expect(project.variables(true).first).to be_protected
|
|
end
|
|
|
|
it 'edits variable to be unprotected' do
|
|
project.variables.first.update(protected: true)
|
|
|
|
page.within('.variables-table') do
|
|
click_on 'Update'
|
|
end
|
|
|
|
expect(page).to have_content('Update variable')
|
|
uncheck('Protected')
|
|
click_button('Save variable')
|
|
|
|
expect(page).to have_content('Variable was successfully updated.')
|
|
expect(project.variables(true).first).not_to be_protected
|
|
end
|
|
end
|