130 lines
3.7 KiB
Ruby
130 lines
3.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe Users::ActivityService do
|
|
include ExclusiveLeaseHelpers
|
|
|
|
let(:user) { create(:user, last_activity_on: last_activity_on) }
|
|
|
|
subject { described_class.new(user) }
|
|
|
|
describe '#execute', :clean_gitlab_redis_shared_state do
|
|
context 'when last activity is nil' do
|
|
let(:last_activity_on) { nil }
|
|
|
|
it 'updates last_activity_on for the user' do
|
|
expect { subject.execute }
|
|
.to change(user, :last_activity_on).from(last_activity_on).to(Date.today)
|
|
end
|
|
end
|
|
|
|
context 'when last activity is in the past' do
|
|
let(:last_activity_on) { Date.today - 1.week }
|
|
|
|
it 'updates last_activity_on for the user' do
|
|
expect { subject.execute }
|
|
.to change(user, :last_activity_on)
|
|
.from(last_activity_on)
|
|
.to(Date.today)
|
|
end
|
|
|
|
it 'tries to obtain ExclusiveLease' do
|
|
expect(Gitlab::ExclusiveLease).to receive(:new).with("activity_service:#{user.id}", anything).and_call_original
|
|
|
|
subject.execute
|
|
end
|
|
end
|
|
|
|
context 'when a bad object is passed' do
|
|
let(:fake_object) { double(username: 'hello') }
|
|
|
|
it 'does not record activity' do
|
|
service = described_class.new(fake_object)
|
|
|
|
expect(service).not_to receive(:record_activity)
|
|
|
|
service.execute
|
|
end
|
|
end
|
|
|
|
context 'when last activity is today' do
|
|
let(:last_activity_on) { Date.today }
|
|
|
|
it 'does not update last_activity_on' do
|
|
expect { subject.execute }.not_to change(user, :last_activity_on)
|
|
end
|
|
|
|
it 'does not try to obtain ExclusiveLease' do
|
|
expect(Gitlab::ExclusiveLease).not_to receive(:new).with("activity_service:#{user.id}", anything)
|
|
|
|
subject.execute
|
|
end
|
|
end
|
|
|
|
context 'when in GitLab read-only instance' do
|
|
let(:last_activity_on) { nil }
|
|
|
|
before do
|
|
allow(Gitlab::Database).to receive(:read_only?).and_return(true)
|
|
end
|
|
|
|
it 'does not update last_activity_on' do
|
|
expect { subject.execute }.not_to change(user, :last_activity_on)
|
|
end
|
|
end
|
|
|
|
context 'when a lease could not be obtained' do
|
|
let(:last_activity_on) { nil }
|
|
|
|
it 'does not update last_activity_on' do
|
|
stub_exclusive_lease_taken("activity_service:#{user.id}", timeout: 1.minute.to_i)
|
|
|
|
expect { subject.execute }.not_to change(user, :last_activity_on)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'with DB Load Balancing' do
|
|
let(:user) { create(:user, last_activity_on: last_activity_on) }
|
|
|
|
context 'when last activity is in the past' do
|
|
let(:user) { create(:user, last_activity_on: Date.today - 1.week) }
|
|
|
|
context 'database load balancing is configured', :db_load_balancing do
|
|
before do
|
|
allow(ActiveRecord::Base).to receive(:connection).and_return(::Gitlab::Database::LoadBalancing.proxy)
|
|
end
|
|
|
|
let(:service) do
|
|
service = described_class.new(user)
|
|
|
|
::Gitlab::Database::LoadBalancing::Session.clear_session
|
|
|
|
service
|
|
end
|
|
|
|
it 'does not stick to primary' do
|
|
expect(::Gitlab::Database::LoadBalancing::Session.current).not_to be_performed_write
|
|
|
|
service.execute
|
|
|
|
expect(user.last_activity_on).to eq(Date.today)
|
|
expect(::Gitlab::Database::LoadBalancing::Session.current).to be_performed_write
|
|
expect(::Gitlab::Database::LoadBalancing::Session.current).not_to be_using_primary
|
|
end
|
|
end
|
|
|
|
context 'database load balancing is not configured' do
|
|
let(:service) { described_class.new(user) }
|
|
|
|
it 'updates user without error' do
|
|
service.execute
|
|
|
|
expect(user.last_activity_on).to eq(Date.today)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|