37b17fa61a
Adding, destroying and toggling emoji previously lacked services and instead were performed through methods called on Awardable models. This led to inconsistencies where relevant todos would be marked as done only when emoji were awarded through our controllers, but not through the API. Todos could also be marked as done when an emoji was being removed. Behaviour changes - Awarding emoji through the API will now mark a relevant Todo as done - Toggling an emoji off (destroying it) through our controllers will no longer mark a relevant Todo as done Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63372
42 lines
1.1 KiB
Ruby
42 lines
1.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
module AwardEmojis
|
|
class AddService < AwardEmojis::BaseService
|
|
include Gitlab::Utils::StrongMemoize
|
|
|
|
def execute
|
|
unless awardable.user_can_award?(current_user)
|
|
return error('User cannot award emoji to awardable', status: :forbidden)
|
|
end
|
|
|
|
unless awardable.emoji_awardable?
|
|
return error('Awardable cannot be awarded emoji', status: :unprocessable_entity)
|
|
end
|
|
|
|
award = awardable.award_emoji.create(name: name, user: current_user)
|
|
|
|
if award.persisted?
|
|
TodoService.new.new_award_emoji(todoable, current_user) if todoable
|
|
success(award: award)
|
|
else
|
|
error(award.errors.full_messages, award: award)
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def todoable
|
|
strong_memoize(:todoable) do
|
|
case awardable
|
|
when Note
|
|
# We don't create todos for personal snippet comments for now
|
|
awardable.noteable unless awardable.for_personal_snippet?
|
|
when MergeRequest, Issue
|
|
awardable
|
|
when Snippet
|
|
nil
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|