886f00bcba
This backports the changes made in EE to fix merge request approvers from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9574.
93 lines
2.6 KiB
Ruby
93 lines
2.6 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe CommitCollection do
|
|
let(:project) { create(:project, :repository) }
|
|
let(:commit) { project.commit("c1c67abbaf91f624347bb3ae96eabe3a1b742478") }
|
|
|
|
describe '#each' do
|
|
it 'yields every commit' do
|
|
collection = described_class.new(project, [commit])
|
|
|
|
expect { |b| collection.each(&b) }.to yield_with_args(commit)
|
|
end
|
|
end
|
|
|
|
describe '.authors' do
|
|
it 'returns a relation of users when users are found' do
|
|
user = create(:user, email: commit.author_email.upcase)
|
|
collection = described_class.new(project, [commit])
|
|
|
|
expect(collection.authors).to contain_exactly(user)
|
|
end
|
|
|
|
it 'returns empty array when authors cannot be found' do
|
|
collection = described_class.new(project, [commit])
|
|
|
|
expect(collection.authors).to be_empty
|
|
end
|
|
|
|
it 'excludes authors of merge commits' do
|
|
commit = project.commit("60ecb67744cb56576c30214ff52294f8ce2def98")
|
|
create(:user, email: commit.author_email.upcase)
|
|
collection = described_class.new(project, [commit])
|
|
|
|
expect(collection.authors).to be_empty
|
|
end
|
|
end
|
|
|
|
describe '#without_merge_commits' do
|
|
it 'returns all commits except merge commits' do
|
|
collection = described_class.new(project, [
|
|
build(:commit),
|
|
build(:commit, :merge_commit)
|
|
])
|
|
|
|
expect(collection.without_merge_commits.size).to eq(1)
|
|
end
|
|
end
|
|
|
|
describe '#with_pipeline_status' do
|
|
it 'sets the pipeline status for every commit so no additional queries are necessary' do
|
|
create(
|
|
:ci_empty_pipeline,
|
|
ref: 'master',
|
|
sha: commit.id,
|
|
status: 'success',
|
|
project: project
|
|
)
|
|
|
|
collection = described_class.new(project, [commit])
|
|
collection.with_pipeline_status
|
|
|
|
recorder = ActiveRecord::QueryRecorder.new do
|
|
expect(commit.status).to eq('success')
|
|
end
|
|
|
|
expect(recorder.count).to be_zero
|
|
end
|
|
end
|
|
|
|
describe '#respond_to_missing?' do
|
|
it 'returns true when the underlying Array responds to the message' do
|
|
collection = described_class.new(project, [])
|
|
|
|
expect(collection.respond_to?(:last)).to eq(true)
|
|
end
|
|
|
|
it 'returns false when the underlying Array does not respond to the message' do
|
|
collection = described_class.new(project, [])
|
|
|
|
expect(collection.respond_to?(:foo)).to eq(false)
|
|
end
|
|
end
|
|
|
|
describe '#method_missing' do
|
|
it 'delegates undefined methods to the underlying Array' do
|
|
collection = described_class.new(project, [commit])
|
|
|
|
expect(collection.length).to eq(1)
|
|
expect(collection.last).to eq(commit)
|
|
expect(collection).not_to be_empty
|
|
end
|
|
end
|
|
end
|