104 lines
3.3 KiB
Ruby
104 lines
3.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.shared_examples 'cache counters invalidator' do
|
|
it 'invalidates counter cache for assignees' do
|
|
expect_any_instance_of(User).to receive(:invalidate_merge_request_cache_counts)
|
|
|
|
described_class.new(project: project, current_user: user).execute(merge_request)
|
|
end
|
|
end
|
|
|
|
RSpec.shared_examples 'updating a single task' do
|
|
def update_issuable(opts)
|
|
issuable = try(:issue) || try(:merge_request)
|
|
described_class.new(project: project, current_user: user, params: opts).execute(issuable)
|
|
end
|
|
|
|
before do
|
|
update_issuable(description: "- [ ] Task 1\n- [ ] Task 2")
|
|
end
|
|
|
|
context 'usage counters' do
|
|
it 'update as expected' do
|
|
if try(:merge_request)
|
|
expect(Gitlab::UsageDataCounters::MergeRequestActivityUniqueCounter)
|
|
.to receive(:track_task_item_status_changed).once.with(user: user)
|
|
else
|
|
expect(Gitlab::UsageDataCounters::MergeRequestActivityUniqueCounter)
|
|
.not_to receive(:track_task_item_status_changed)
|
|
end
|
|
|
|
update_issuable(
|
|
update_task: {
|
|
index: 1,
|
|
checked: true,
|
|
line_source: '- [ ] Task 1',
|
|
line_number: 1
|
|
}
|
|
)
|
|
end
|
|
end
|
|
|
|
context 'when a task is marked as completed' do
|
|
before do
|
|
update_issuable(update_task: { index: 1, checked: true, line_source: '- [ ] Task 1', line_number: 1 })
|
|
end
|
|
|
|
it 'creates system note about task status change' do
|
|
note1 = find_note('marked the checklist item **Task 1** as completed')
|
|
|
|
expect(note1).not_to be_nil
|
|
|
|
description_notes = find_notes('description')
|
|
expect(description_notes.length).to eq(1)
|
|
end
|
|
end
|
|
|
|
context 'when a task is marked as incomplete' do
|
|
before do
|
|
update_issuable(description: "- [x] Task 1\n- [X] Task 2")
|
|
update_issuable(update_task: { index: 2, checked: false, line_source: '- [X] Task 2', line_number: 2 })
|
|
end
|
|
|
|
it 'creates system note about task status change' do
|
|
note1 = find_note('marked the checklist item **Task 2** as incomplete')
|
|
|
|
expect(note1).not_to be_nil
|
|
|
|
description_notes = find_notes('description')
|
|
expect(description_notes.length).to eq(1)
|
|
end
|
|
end
|
|
|
|
context 'when the task position has been modified' do
|
|
before do
|
|
update_issuable(description: "- [ ] Task 1\n- [ ] Task 3\n- [ ] Task 2")
|
|
end
|
|
|
|
it 'raises an exception' do
|
|
expect(Note.count).to eq(2)
|
|
expect do
|
|
update_issuable(update_task: { index: 2, checked: true, line_source: '- [ ] Task 2', line_number: 2 })
|
|
end.to raise_error(ActiveRecord::StaleObjectError)
|
|
expect(Note.count).to eq(2)
|
|
end
|
|
end
|
|
|
|
context 'when the content changes but not task line number' do
|
|
before do
|
|
update_issuable(description: "Paragraph\n\n- [ ] Task 1\n- [x] Task 2")
|
|
update_issuable(description: "Paragraph with more words\n\n- [ ] Task 1\n- [x] Task 2")
|
|
update_issuable(update_task: { index: 2, checked: false, line_source: '- [x] Task 2', line_number: 4 })
|
|
end
|
|
|
|
it 'creates system note about task status change' do
|
|
note1 = find_note('marked the checklist item **Task 2** as incomplete')
|
|
|
|
expect(note1).not_to be_nil
|
|
|
|
description_notes = find_notes('description')
|
|
expect(description_notes.length).to eq(2)
|
|
end
|
|
end
|
|
end
|