0fdfd2dd6e
Here was the problem: 1. When determining whether a given blob is viewable text, gitlab_git reads the first 1024 bytes and checks with Linguist whether it is a text or binary file. 2. If the blob is text, GitLab will attempt to display it. 3. However, if the text has binary characters after the first 1024 bytes, then GitLab will attempt to load the entire contents, but the encoding will be ASCII-8BIT since there are binary characters. 4. The Error 500 results when GitLab attempts to display a mix UTF-8 and ASCII-8BIT. To fix this, we load as much data as we are willing to display so that the detection will work properly. Requires an update to gitlab_git: gitlab-org/gitlab_git!86 Closes #13826
67 lines
1.6 KiB
Ruby
67 lines
1.6 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Projects::BlobController do
|
|
let(:project) { create(:project) }
|
|
let(:user) { create(:user) }
|
|
|
|
before do
|
|
sign_in(user)
|
|
|
|
project.team << [user, :master]
|
|
|
|
allow(project).to receive(:branches).and_return(['master', 'foo/bar/baz'])
|
|
allow(project).to receive(:tags).and_return(['v1.0.0', 'v2.0.0'])
|
|
controller.instance_variable_set(:@project, project)
|
|
end
|
|
|
|
describe "GET show" do
|
|
render_views
|
|
|
|
before do
|
|
get(:show,
|
|
namespace_id: project.namespace.to_param,
|
|
project_id: project.to_param,
|
|
id: id)
|
|
end
|
|
|
|
context "valid branch, valid file" do
|
|
let(:id) { 'master/README.md' }
|
|
it { is_expected.to respond_with(:success) }
|
|
end
|
|
|
|
context "valid branch, invalid file" do
|
|
let(:id) { 'master/invalid-path.rb' }
|
|
it { is_expected.to respond_with(:not_found) }
|
|
end
|
|
|
|
context "invalid branch, valid file" do
|
|
let(:id) { 'invalid-branch/README.md' }
|
|
it { is_expected.to respond_with(:not_found) }
|
|
end
|
|
|
|
context "binary file" do
|
|
let(:id) { 'binary-encoding/encoding/binary-1.bin' }
|
|
it { is_expected.to respond_with(:success) }
|
|
end
|
|
end
|
|
|
|
describe 'GET show with tree path' do
|
|
render_views
|
|
|
|
before do
|
|
get(:show,
|
|
namespace_id: project.namespace.to_param,
|
|
project_id: project.to_param,
|
|
id: id)
|
|
controller.instance_variable_set(:@blob, nil)
|
|
end
|
|
|
|
context 'redirect to tree' do
|
|
let(:id) { 'markdown/doc' }
|
|
it 'redirects' do
|
|
expect(subject).
|
|
to redirect_to("/#{project.path_with_namespace}/tree/markdown/doc")
|
|
end
|
|
end
|
|
end
|
|
end
|