gitlab-org--gitlab-foss/spec
Fatih Acet 60b92c551d Merge branch '22221-tags-are-not-available-from-repository-compare-view' into 'master'
Changed compare dropdowns to dropdowns with search input

## What does this MR do?

This changes the compare dropdowns from text inputs, that when clicked, open a dropdown of branches/tags to dropdowns that have a dropdown toggle and an isolated search input.

## Are there points in the code the reviewer needs to double check?

## Why was this MR needed?

This was needed to fix the poor UX highlighted in #22221, where opening the dropdown showed an initially filtered set of results because the dropdown toggle was the dropdown filter itself. The compare page is always loaded with `master` as each branch/tag selection, so when opening the dropdown, it would only show results matching `master`.

## Screenshots (if relevant)

![2016-09-27_18.28.10](/uploads/0ea1d91cb592c6e140ed62c336e77227/2016-09-27_18.28.10.gif)

## Does this MR meet the acceptance criteria?

- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [ ] Added for this feature/bug
  - [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?


Closes #22221

See merge request !6550
2016-10-01 11:38:01 +00:00
..
config Small refactor and a few documentation fixes 2016-08-04 19:02:39 +02:00
controllers fix broken repo 500 errors in UI and added relevant specs 2016-09-29 16:58:14 +02:00
factories fix broken repo 500 errors in UI and added relevant specs 2016-09-29 16:58:14 +02:00
features Merge branch '22221-tags-are-not-available-from-repository-compare-view' into 'master' 2016-10-01 11:38:01 +00:00
finders New AccessRequestsFinder 2016-09-28 08:46:59 +02:00
fixtures Returns the total number of issues in the JSON response 2016-08-31 09:30:37 +01:00
helpers Small improvements thanks to Robert's feedback 2016-09-30 12:02:54 +02:00
initializers Give priority to environment variables 2016-08-03 15:48:48 +01:00
javascripts Send ajax request for label update only if they are changed (#19472 !5071) 2016-09-27 10:23:15 -05:00
lib Expose jobs to view 2016-09-30 12:22:55 +02:00
mailers Wrap List-Unsubscribe link in angle brackets 2016-09-26 16:01:17 +01:00
models Allowing ">" to be used for Milestone models's title and storing the value in db as unescaped. 2016-09-29 19:28:38 -07:00
policies Test if issue authors can access private projects 2016-09-20 14:57:23 -03:00
requests Merge branch 'koding-setting-api' into 'master' 2016-09-30 11:06:08 +00:00
routing Fix markdown help references 2016-08-26 09:38:21 -05:00
services Close todos when accepting a MR via the API. 2016-09-29 14:51:12 -04:00
support Small improvements thanks to Robert's feedback 2016-09-30 12:02:54 +02:00
tasks/gitlab Use `File::exist?` instead of `File::exists?` 2016-08-11 13:54:45 +03:00
uploaders
views Merge branch '21744-fix-missing-values-in-linter' into 'master' 2016-09-30 16:51:47 +00:00
workers Added cron to prune events older than 12 months. 2016-09-07 19:41:25 +02:00
factories_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
rails_helper.rb
simplecov_env.rb Bump SimpleCov merge timeout to 365 days 2016-08-22 13:44:14 +02:00
spec_helper.rb Upgrade Devise from 4.1.1 to 4.2.0. 2016-09-27 20:08:49 -06:00
teaspoon_env.rb Add test coverage analysis for CoffeeScript (!5052) 2016-08-07 21:52:37 +02:00