d30a90a354
* Prevent creating notes on inaccessible MRs This applies the notes rules at the MR scope. Rather than adding extra rules to the Project level policy, preventing :create_note here is better since it only prevents creating notes on MRs. * Prevent creating notes in inaccessible Issues without this policy, non-team-members are allowed to comment on issues even when the project has the private-issues policy set. This means that without this change, users are allowed to comment on issues that they cannot read. * Add CHANGELOG entry
28 lines
879 B
Ruby
28 lines
879 B
Ruby
# frozen_string_literal: true
|
|
|
|
class IssuePolicy < IssuablePolicy
|
|
# This class duplicates the same check of Issue#readable_by? for performance reasons
|
|
# Make sure to sync this class checks with issue.rb to avoid security problems.
|
|
# Check commit 002ad215818450d2cbbc5fa065850a953dc7ada8 for more information.
|
|
|
|
extend ProjectPolicy::ClassMethods
|
|
|
|
desc "User can read confidential issues"
|
|
condition(:can_read_confidential) do
|
|
@user && IssueCollection.new([@subject]).visible_to(@user).any?
|
|
end
|
|
|
|
desc "Issue is confidential"
|
|
condition(:confidential, scope: :subject) { @subject.confidential? }
|
|
|
|
rule { confidential & ~can_read_confidential }.policy do
|
|
prevent(*create_read_update_admin_destroy(:issue))
|
|
prevent :read_issue_iid
|
|
end
|
|
|
|
rule { ~can?(:read_issue) }.prevent :create_note
|
|
|
|
rule { locked }.policy do
|
|
prevent :reopen_issue
|
|
end
|
|
end
|