gitlab-org--gitlab-foss/danger
Yorick Peterse 4ef1dd09dd
Improve Emoji detection in commit messages
This changes our Danger integration so that it is smarter about
detecting GitLab emoji in commit messages. This is done using a two step
process:

1. We use the old regular expression to determine if a commit message
   _might_ include an emoji.

2. If this regular expression matches, we then check for all existing
   emoji names in the commit message. This might be a wee bit expensive,
   but because we couple it with the previous step it should be rarely
   executed.

This ensures we don't trigger an error when a commit message includes
text such as `:foo:bar:`, which is not a valid Emoji.

Fixes https://gitlab.com/gitlab-org/release/framework/issues/15
2018-09-18 16:22:29 +02:00
..
changelog Drop WIP from changelog command in Danger comment 2018-08-24 20:54:55 +00:00
changes_size Autocorrect RuboCop violations in danger/**/Dangerfile 2018-07-11 14:44:35 -05:00
commit_messages Improve Emoji detection in commit messages 2018-09-18 16:22:29 +02:00
database Fix regexp for detected `db/schema.rb` and `ee/db/geo/schema.rb` 2018-07-26 10:31:45 +12:00
documentation Add Documentation Dangerfile 2018-09-06 10:50:35 +02:00
frozen_string Make the frozen_string Danger check more resilient 2018-07-25 14:32:44 -07:00
gemfile Autocorrect RuboCop violations in danger/**/Dangerfile 2018-07-11 14:44:35 -05:00
metadata Fix wording in Danger warning about MRs to non-master 2018-09-04 09:57:22 +01:00
specs Improve danger/specs/Dangerfile by not requiring new specs if specific labels are applied 2018-07-17 09:43:47 +02:00