kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/spec/models/project_services
History
Rémy Coutable 624f35beed Merge branch '13333-consider-updating-http-parser-rb-to-0-6-0' into 'master' 
Replace the tinder gem by bare HTTP requests

## What does this MR do?

It removes the `tinder` gem (used to talk to the Campfire API) and replaces its use by bare HTTP requests.

## Are there points in the code the reviewer needs to double check?

N/A.

## Why was this MR needed?

To simplify the potential dependency hell discussed in #13333.  
The initial issue was about updating `http_parser.rb` which was required by `twitter-stream` which was required by `tinder`.  
Those 3 gems are not needed anymore.  

## What are the relevant issue numbers?

#13333

## Screenshots (if relevant)

N/A.

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
Closes #13333

See merge request !5758
 		2016-08-11 11:23:53 +00:00
..
slack_service adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
asana_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
assembla_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
bamboo_service_spec.rb Factorize duplicated code into a method in BambooService and update specs 2016-06-14 10:07:37 +02:00
bugzilla_service_spec.rb Added Bugzilla as external issue tracker option 2016-06-29 06:01:54 -04:00
buildkite_service_spec.rb Avoid `describe`-ing symbols in specs 2016-07-12 10:27:58 -05:00
builds_email_service_spec.rb Allow build email service to be tested 2016-07-15 20:38:27 -03:00
campfire_service_spec.rb Replace the tinder gem by bare HTTP requests 2016-08-11 08:52:13 +02:00
custom_issue_tracker_service_spec.rb Ensure URL in all Service subclasses are valid 2016-04-25 15:28:24 -04:00
drone_ci_service_spec.rb Ensure URL in all Service subclasses are valid 2016-04-25 15:28:24 -04:00
emails_on_push_service_spec.rb Ensure URL in all Service subclasses are valid 2016-04-25 15:28:24 -04:00
external_wiki_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
flowdock_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
gemnasium_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
gitlab_issue_tracker_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
hipchat_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
irker_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
jira_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
pivotaltracker_service_spec.rb Ensure URL in all Service subclasses are valid 2016-04-25 15:28:24 -04:00
pushover_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
redmine_service_spec.rb Ensure URL in all Service subclasses are valid 2016-04-25 15:28:24 -04:00
slack_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
teamcity_service_spec.rb Fix broken URI joining for `teamcity_url` with suffixes 2016-06-14 10:07:37 +02:00