6cfd028278
So we extend Gitlab::Email::Receiver for this new behaviour,
however we might want to split it into another class for better
testing it.
Another issue is that, currently it's using this to parse project
identifier:
Gitlab::IncomingEmail.key_from_address
Which is using:
Gitlab.config.incoming_email.address
for the receiver name. This is probably `reply` because it's used
for replying to a specific issue. We might want to introduce another
config for this, or just use `reply` instead of `incoming`.
I'll prefer to introduce a new config for this, or just change
`reply` to `incoming` because it would make sense for replying to
there, too.
The email template used in tests were copied and modified from:
`emails/valid_reply.eml` which I hope is ok.
23 lines
1.6 KiB
Text
23 lines
1.6 KiB
Text
Return-Path: <jake@adventuretime.ooo>
|
|
Received: from iceking.adventuretime.ooo ([unix socket]) by iceking (Cyrus v2.2.13-Debian-2.2.13-19+squeeze3) with LMTPA; Thu, 13 Jun 2013 17:03:50 -0400
|
|
Received: from mail-ie0-x234.google.com (mail-ie0-x234.google.com [IPv6:2607:f8b0:4001:c03::234]) by iceking.adventuretime.ooo (8.14.3/8.14.3/Debian-9.4) with ESMTP id r5DL3nFJ016967 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for <incoming+gitlabhq/gitlabhq@appmail.adventuretime.ooo>; Thu, 13 Jun 2013 17:03:50 -0400
|
|
Received: by mail-ie0-f180.google.com with SMTP id f4so21977375iea.25 for <incoming+gitlabhq/gitlabhq@appmail.adventuretime.ooo>; Thu, 13 Jun 2013 14:03:48 -0700
|
|
Received: by 10.0.0.1 with HTTP; Thu, 13 Jun 2013 14:03:48 -0700
|
|
Date: Thu, 13 Jun 2013 17:03:48 -0400
|
|
From: Jake the Dog <jake@adventuretime.ooo>
|
|
To: incoming+gitlabhq/gitlabhq@appmail.adventuretime.ooo
|
|
Message-ID: <CADkmRc+rNGAGGbV2iE5p918UVy4UyJqVcXRO2=otppgzduJSg@mail.gmail.com>
|
|
Subject: New Issue by email
|
|
Mime-Version: 1.0
|
|
Content-Type: text/plain;
|
|
charset=ISO-8859-1
|
|
Content-Transfer-Encoding: 7bit
|
|
X-Sieve: CMU Sieve 2.2
|
|
X-Received: by 10.0.0.1 with SMTP id n7mr11234144ipb.85.1371157428600; Thu,
|
|
13 Jun 2013 14:03:48 -0700 (PDT)
|
|
X-Scanned-By: MIMEDefang 2.69 on IPv6:2001:470:1d:165::1
|
|
|
|
The reply by email functionality should be extended to allow creating a new issue by email.
|
|
|
|
* Allow an admin to specify which project the issue should be created under by checking the sender domain.
|
|
* Possibly allow the use of regular expression matches within the subject/body to specify which project the issue should be created under.
|