kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss

History

Sean McGivern 0c3ec51f40 Merge branch 'issue_40500' into 'master' Improve filtering issues by label performance Closes #40500 and #37143 See merge request gitlab-org/gitlab-ce!16136		2018-01-05 17:54:56 +00:00
..
admin
concerns
access_requests_finder.rb
autocomplete_users_finder.rb
branches_finder.rb
clusters_finder.rb	Use attr_reader instead of instance variables	2017-11-28 14:39:18 +01:00
contributed_projects_finder.rb
environments_finder.rb
events_finder.rb
fork_projects_finder.rb
group_descendants_finder.rb
group_finder.rb
group_members_finder.rb
group_projects_finder.rb
groups_finder.rb
issuable_finder.rb	Improve filtering issues by label performance	2018-01-05 13:26:30 -02:00
issues_finder.rb
joined_groups_finder.rb
labels_finder.rb	EE-BACKPORT group boards	2018-01-04 17:28:10 -02:00
members_finder.rb
merge_request_target_project_finder.rb
merge_requests_finder.rb
milestones_finder.rb
move_to_project_finder.rb
notes_finder.rb
personal_access_tokens_finder.rb
personal_projects_finder.rb
pipeline_schedules_finder.rb
pipelines_finder.rb
projects_finder.rb
README.md
runner_jobs_finder.rb
snippets_finder.rb
tags_finder.rb
todos_finder.rb
union_finder.rb
users_finder.rb	Added default order to UserFinder	2017-12-04 09:49:53 +00:00

README.md

Finders

This type of classes responsible for collection items based on different conditions. To prevent lookup methods in models like this:

class Project
  def issues_for_user_filtered_by(user, filter)
    # A lot of logic not related to project model itself
  end
end

issues = project.issues_for_user_filtered_by(user, params)

Better use this:

issues = IssuesFinder.new(project, user, filter).execute

It will help keep models thiner.