ef0055b52d
The upgrade from Rails v4.1.2 to v4.1.9 (76aad9b76e) caused slashes in a tree to be escaped automatically.
Using wildcard globs prevents this behavior.
Closes #1478, #1459
76 lines
2.2 KiB
Ruby
76 lines
2.2 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe ExtractsPath do
|
|
include ExtractsPath
|
|
include RepoHelpers
|
|
include Rails.application.routes.url_helpers
|
|
|
|
let(:project) { double('project') }
|
|
|
|
before do
|
|
@project = project
|
|
project.stub(repository: double(ref_names: ['master', 'foo/bar/baz', 'v1.0.0', 'v2.0.0']))
|
|
project.stub(path_with_namespace: 'gitlab/gitlab-ci')
|
|
end
|
|
|
|
describe '#assign_ref' do
|
|
let(:ref) { sample_commit[:id] }
|
|
let(:params) { {path: sample_commit[:line_code_path], ref: ref} }
|
|
|
|
before do
|
|
@project = create(:project)
|
|
end
|
|
|
|
it "log tree path should have no escape sequences" do
|
|
assign_ref_vars
|
|
expect(@logs_path).to eq("/#{@project.path_with_namespace}/refs/#{ref}/logs_tree/files/ruby/popen.rb")
|
|
end
|
|
end
|
|
|
|
describe '#extract_ref' do
|
|
it "returns an empty pair when no @project is set" do
|
|
@project = nil
|
|
expect(extract_ref('master/CHANGELOG')).to eq(['', ''])
|
|
end
|
|
|
|
context "without a path" do
|
|
it "extracts a valid branch" do
|
|
expect(extract_ref('master')).to eq(['master', ''])
|
|
end
|
|
|
|
it "extracts a valid tag" do
|
|
expect(extract_ref('v2.0.0')).to eq(['v2.0.0', ''])
|
|
end
|
|
|
|
it "extracts a valid commit ref without a path" do
|
|
expect(extract_ref('f4b14494ef6abf3d144c28e4af0c20143383e062')).to eq(
|
|
['f4b14494ef6abf3d144c28e4af0c20143383e062', '']
|
|
)
|
|
end
|
|
|
|
it "falls back to a primitive split for an invalid ref" do
|
|
expect(extract_ref('stable')).to eq(['stable', ''])
|
|
end
|
|
end
|
|
|
|
context "with a path" do
|
|
it "extracts a valid branch" do
|
|
expect(extract_ref('foo/bar/baz/CHANGELOG')).to eq(['foo/bar/baz', 'CHANGELOG'])
|
|
end
|
|
|
|
it "extracts a valid tag" do
|
|
expect(extract_ref('v2.0.0/CHANGELOG')).to eq(['v2.0.0', 'CHANGELOG'])
|
|
end
|
|
|
|
it "extracts a valid commit SHA" do
|
|
expect(extract_ref('f4b14494ef6abf3d144c28e4af0c20143383e062/CHANGELOG')).to eq(
|
|
['f4b14494ef6abf3d144c28e4af0c20143383e062', 'CHANGELOG']
|
|
)
|
|
end
|
|
|
|
it "falls back to a primitive split for an invalid ref" do
|
|
expect(extract_ref('stable/CHANGELOG')).to eq(['stable', 'CHANGELOG'])
|
|
end
|
|
end
|
|
end
|
|
end
|