gitlab-org--gitlab-foss/app/finders
Yorick Peterse f0e7b5e7a3
Cleaned up CI runner administration code
In https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19625 some
changes were introduced that do not meet our abstraction reuse rules.
This commit cleans up some of these changes so the requirements are met.

Most notably, sorting of the runners in Admin::RunnersFinder has been
delegated to Ci::Runner.order_by, similar to how we order data in
models that include the Sortable module. If we need more sort orders in
the future we can include Sortable and have Ci::Runner.order_by call
`super` to delegate to Sortable.order_by.
2018-09-14 15:05:46 +02:00
..
admin Cleaned up CI runner administration code 2018-09-14 15:05:46 +02:00
autocomplete Disable existing offenses for the CodeReuse cops 2018-09-11 17:32:00 +02:00
concerns Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
README.md Set milestone on new issue when creating issue from index with milestone filter active. 2015-05-27 14:22:11 +02:00
access_requests_finder.rb Enable frozen string in app/graphql + app/finders 2018-09-11 12:15:23 -07:00
awarded_emoji_finder.rb Refactor AutocompleteController 2018-08-20 13:53:00 +02:00
branches_finder.rb Enable frozen string in app/graphql + app/finders 2018-09-11 12:15:23 -07:00
clusters_finder.rb Enable frozen string in app/graphql + app/finders 2018-09-11 12:15:23 -07:00
contributed_projects_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
environments_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
events_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
fork_projects_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
group_descendants_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
group_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
group_members_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
group_projects_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
groups_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
issuable_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
issues_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
joined_groups_finder.rb Enable frozen string in app/graphql + app/finders 2018-09-11 12:15:23 -07:00
labels_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
license_template_finder.rb Enable frozen string in app/graphql + app/finders 2018-09-11 12:15:23 -07:00
members_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
merge_request_target_project_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
merge_requests_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
milestones_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
notes_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
personal_access_tokens_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
personal_projects_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
pipeline_schedules_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
pipelines_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
projects_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
runner_jobs_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
snippets_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
tags_finder.rb Enable frozen string in app/graphql + app/finders 2018-09-11 12:15:23 -07:00
template_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
todos_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
union_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
user_finder.rb Disable existing offenses for the CodeReuse cops 2018-09-11 17:32:00 +02:00
user_recent_events_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
users_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00

README.md

Finders

This type of classes responsible for collection items based on different conditions. To prevent lookup methods in models like this:

class Project
  def issues_for_user_filtered_by(user, filter)
    # A lot of logic not related to project model itself
  end
end

issues = project.issues_for_user_filtered_by(user, params)

Better use this:

issues = IssuesFinder.new(project, user, filter).execute

It will help keep models thiner.