293 lines
9.4 KiB
Ruby
293 lines
9.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
RSpec.describe Gitlab::LegacyGithubImport::Importer do
|
|
shared_examples 'Gitlab::LegacyGithubImport::Importer#execute' do
|
|
let(:expected_not_called) { [] }
|
|
|
|
before do
|
|
allow(project).to receive(:import_data).and_return(double.as_null_object)
|
|
end
|
|
|
|
it 'calls import methods' do
|
|
importer = described_class.new(project)
|
|
|
|
expected_called = [
|
|
:import_labels, :import_milestones, :import_pull_requests, :import_issues,
|
|
:import_wiki, :import_releases, :handle_errors,
|
|
[:import_comments, :issues],
|
|
[:import_comments, :pull_requests]
|
|
]
|
|
|
|
expected_called -= expected_not_called
|
|
|
|
aggregate_failures do
|
|
expected_called.each do |method_name, arg|
|
|
base_expectation = proc { expect(importer).to receive(method_name) }
|
|
arg ? base_expectation.call.with(arg) : base_expectation.call
|
|
end
|
|
|
|
expected_not_called.each do |method_name, arg|
|
|
base_expectation = proc { expect(importer).not_to receive(method_name) }
|
|
arg ? base_expectation.call.with(arg) : base_expectation.call
|
|
end
|
|
end
|
|
|
|
importer.execute
|
|
end
|
|
end
|
|
|
|
shared_examples 'Gitlab::LegacyGithubImport::Importer#execute an error occurs' do
|
|
before do
|
|
allow(project).to receive(:import_data).and_return(double.as_null_object)
|
|
|
|
allow(Rails).to receive(:cache).and_return(ActiveSupport::Cache::MemoryStore.new)
|
|
|
|
allow_any_instance_of(Octokit::Client).to receive(:rate_limit!).and_raise(Octokit::NotFound)
|
|
allow(project.wiki.repository).to receive(:import_repository).and_raise(Gitlab::Git::CommandError)
|
|
|
|
allow_any_instance_of(Octokit::Client).to receive(:user).and_return(octocat)
|
|
allow_any_instance_of(Octokit::Client).to receive(:labels).and_return([label1, label2])
|
|
allow_any_instance_of(Octokit::Client).to receive(:milestones).and_return([milestone, milestone])
|
|
allow_any_instance_of(Octokit::Client).to receive(:issues).and_return([issue1, issue2])
|
|
allow_any_instance_of(Octokit::Client).to receive(:pull_requests).and_return([pull_request, pull_request])
|
|
allow_any_instance_of(Octokit::Client).to receive(:issues_comments).and_raise(Octokit::NotFound)
|
|
allow_any_instance_of(Octokit::Client).to receive(:pull_requests_comments).and_return([])
|
|
allow_any_instance_of(Octokit::Client).to receive(:last_response).and_return(double(rels: { next: nil }))
|
|
allow_any_instance_of(Octokit::Client).to receive(:releases).and_return([release1, release2])
|
|
end
|
|
|
|
let(:label1) do
|
|
{
|
|
name: 'Bug',
|
|
color: 'ff0000',
|
|
url: "#{api_root}/repos/octocat/Hello-World/labels/bug"
|
|
}
|
|
end
|
|
|
|
let(:label2) do
|
|
{
|
|
name: nil,
|
|
color: 'ff0000',
|
|
url: "#{api_root}/repos/octocat/Hello-World/labels/bug"
|
|
}
|
|
end
|
|
|
|
let(:milestone) do
|
|
{
|
|
id: 1347, # For Gitea
|
|
number: 1347,
|
|
state: 'open',
|
|
title: '1.0',
|
|
description: 'Version 1.0',
|
|
due_on: nil,
|
|
created_at: created_at,
|
|
updated_at: updated_at,
|
|
closed_at: nil,
|
|
url: "#{api_root}/repos/octocat/Hello-World/milestones/1"
|
|
}
|
|
end
|
|
|
|
let(:issue1) do
|
|
{
|
|
number: 1347,
|
|
milestone: nil,
|
|
state: 'open',
|
|
title: 'Found a bug',
|
|
body: "I'm having a problem with this.",
|
|
assignee: nil,
|
|
user: octocat,
|
|
comments: 0,
|
|
pull_request: nil,
|
|
created_at: created_at,
|
|
updated_at: updated_at,
|
|
closed_at: nil,
|
|
url: "#{api_root}/repos/octocat/Hello-World/issues/1347",
|
|
labels: [{ name: 'Label #1' }]
|
|
}
|
|
end
|
|
|
|
let(:issue2) do
|
|
{
|
|
number: 1348,
|
|
milestone: nil,
|
|
state: 'open',
|
|
title: nil,
|
|
body: "I'm having a problem with this.",
|
|
assignee: nil,
|
|
user: octocat,
|
|
comments: 0,
|
|
pull_request: nil,
|
|
created_at: created_at,
|
|
updated_at: updated_at,
|
|
closed_at: nil,
|
|
url: "#{api_root}/repos/octocat/Hello-World/issues/1348",
|
|
labels: [{ name: 'Label #2' }]
|
|
}
|
|
end
|
|
|
|
let(:release1) do
|
|
{
|
|
tag_name: 'v1.0.0',
|
|
name: 'First release',
|
|
body: 'Release v1.0.0',
|
|
draft: false,
|
|
created_at: created_at,
|
|
published_at: created_at,
|
|
updated_at: updated_at,
|
|
url: "#{api_root}/repos/octocat/Hello-World/releases/1"
|
|
}
|
|
end
|
|
|
|
let(:release2) do
|
|
{
|
|
tag_name: 'v1.1.0',
|
|
name: 'Second release',
|
|
body: nil,
|
|
draft: false,
|
|
created_at: created_at,
|
|
published_at: created_at,
|
|
updated_at: updated_at,
|
|
url: "#{api_root}/repos/octocat/Hello-World/releases/2"
|
|
}
|
|
end
|
|
|
|
subject { described_class.new(project) }
|
|
|
|
it 'returns true' do
|
|
expect(subject.execute).to eq true
|
|
end
|
|
|
|
it 'does not raise an error' do
|
|
expect { subject.execute }.not_to raise_error
|
|
end
|
|
|
|
it 'stores error messages' do
|
|
error = {
|
|
message: 'The remote data could not be fully imported.',
|
|
errors: [
|
|
{ type: :label, url: "#{api_root}/repos/octocat/Hello-World/labels/bug", errors: "Validation failed: Title can't be blank, Title is invalid" },
|
|
{ type: :issue, url: "#{api_root}/repos/octocat/Hello-World/issues/1348", errors: "Validation failed: Title can't be blank" },
|
|
{ type: :issues_comments, errors: 'Octokit::NotFound' },
|
|
{ type: :wiki, errors: "Gitlab::Git::CommandError" }
|
|
]
|
|
}
|
|
|
|
described_class.new(project).execute
|
|
|
|
expect(project.import_state.last_error).to eq error.to_json
|
|
end
|
|
end
|
|
|
|
shared_examples 'Gitlab::LegacyGithubImport unit-testing' do
|
|
describe '#clean_up_restored_branches' do
|
|
subject { described_class.new(project) }
|
|
|
|
before do
|
|
allow(gh_pull_request).to receive(:source_branch_exists?).at_least(:once) { false }
|
|
allow(gh_pull_request).to receive(:target_branch_exists?).at_least(:once) { false }
|
|
end
|
|
|
|
context 'when pull request stills open' do
|
|
let(:gh_pull_request) { Gitlab::LegacyGithubImport::PullRequestFormatter.new(project, pull_request) }
|
|
|
|
it 'does not remove branches' do
|
|
expect(subject).not_to receive(:remove_branch)
|
|
subject.send(:clean_up_restored_branches, gh_pull_request)
|
|
end
|
|
end
|
|
|
|
context 'when pull request is closed' do
|
|
let(:gh_pull_request) { Gitlab::LegacyGithubImport::PullRequestFormatter.new(project, closed_pull_request) }
|
|
|
|
it 'does remove branches' do
|
|
expect(subject).to receive(:remove_branch).at_least(:twice)
|
|
subject.send(:clean_up_restored_branches, gh_pull_request)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
let(:project) { create(:project, :repository, :wiki_disabled, import_url: "#{repo_root}/octocat/Hello-World.git") }
|
|
let(:octocat) { { id: 123456, login: 'octocat', email: 'octocat@example.com' } }
|
|
let(:credentials) { { user: 'joe' } }
|
|
|
|
let(:created_at) { DateTime.strptime('2011-01-26T19:01:12Z') }
|
|
let(:updated_at) { DateTime.strptime('2011-01-27T19:01:12Z') }
|
|
let(:repository) { { id: 1, fork: false } }
|
|
let(:source_sha) { create(:commit, project: project).id }
|
|
let(:source_branch) { { ref: 'branch-merged', repo: repository, sha: source_sha, user: octocat } }
|
|
let(:target_sha) { create(:commit, project: project, git_commit: RepoHelpers.another_sample_commit).id }
|
|
let(:target_branch) { { ref: 'master', repo: repository, sha: target_sha, user: octocat } }
|
|
let(:pull_request) do
|
|
{
|
|
number: 1347,
|
|
milestone: nil,
|
|
state: 'open',
|
|
title: 'New feature',
|
|
body: 'Please pull these awesome changes',
|
|
head: source_branch,
|
|
base: target_branch,
|
|
assignee: nil,
|
|
user: octocat,
|
|
created_at: created_at,
|
|
updated_at: updated_at,
|
|
closed_at: nil,
|
|
merged_at: nil,
|
|
url: "#{api_root}/repos/octocat/Hello-World/pulls/1347",
|
|
labels: [{ name: 'Label #2' }]
|
|
}
|
|
end
|
|
|
|
let(:closed_pull_request) do
|
|
{
|
|
number: 1347,
|
|
milestone: nil,
|
|
state: 'closed',
|
|
title: 'New feature',
|
|
body: 'Please pull these awesome changes',
|
|
head: source_branch,
|
|
base: target_branch,
|
|
assignee: nil,
|
|
user: octocat,
|
|
created_at: created_at,
|
|
updated_at: updated_at,
|
|
closed_at: updated_at,
|
|
merged_at: nil,
|
|
url: "#{api_root}/repos/octocat/Hello-World/pulls/1347",
|
|
labels: [{ name: 'Label #2' }]
|
|
}
|
|
end
|
|
|
|
context 'when importing a Gitea project' do
|
|
let(:api_root) { 'https://try.gitea.io/api/v1' }
|
|
let(:repo_root) { 'https://try.gitea.io' }
|
|
|
|
subject { described_class.new(project) }
|
|
|
|
before do
|
|
project.update!(import_type: 'gitea', import_url: "#{repo_root}/foo/group/project.git")
|
|
end
|
|
|
|
it_behaves_like 'Gitlab::LegacyGithubImport::Importer#execute' do
|
|
let(:expected_not_called) { [:import_releases, [:import_comments, :pull_requests]] }
|
|
end
|
|
|
|
it_behaves_like 'Gitlab::LegacyGithubImport::Importer#execute an error occurs'
|
|
it_behaves_like 'Gitlab::LegacyGithubImport unit-testing'
|
|
|
|
describe '#client' do
|
|
it 'instantiates a Client' do
|
|
allow(project).to receive(:import_data).and_return(double(credentials: credentials))
|
|
expect(Gitlab::LegacyGithubImport::Client).to receive(:new).with(
|
|
credentials[:user],
|
|
{ host: "#{repo_root}:443/foo", api_version: 'v1' }
|
|
)
|
|
|
|
subject.client
|
|
end
|
|
end
|
|
end
|
|
end
|