gitlab-org--gitlab-foss/spec/lib
Fatih Acet a625757cb4 Merge branch 'fix-already-selected-activity-link' into 'master'
Fix inconsistent highlighting of already selected activity nav-links

## What does this MR do?

*  Remove edge case where user could deselect an activity nav-link (which seems to be returning all the events)
*  Explicitly add an `All` tab to return all the events

## Are there points in the code the reviewer needs to double check?
Shouldn't be

## Why was this MR needed?
Resolves existing UI inconsistency

## Screenshots (if relevant)
Before:
![4OzkoQVJYc](/uploads/fd2a7fdbde2159e875482ec7b828fe60/4OzkoQVJYc.gif)

After:
![E0lj8UhEUU](/uploads/7eb5155861eb79d72957de04c9f172c9/E0lj8UhEUU.gif)

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

*  Closes #21631
*  Closes #21452


See merge request !6091
2016-10-06 21:34:03 +00:00
..
banzai Merge branch 'kradydal/gitlab-ce-20989-disable-all-for-non-project-members' 2016-10-05 18:54:36 +02:00
ci Improve JwtController implementation 2016-09-20 19:15:13 +02:00
constraints Make user constrainer lookup same as controller and add more constrainer tests 2016-10-06 19:50:48 +03:00
container_registry Explicitly remove authorization token and make sure that invalid addresses are properly handled 2016-07-15 17:35:23 +02:00
gitlab Use higher size on Gitlab::Redis connection pool on Sidekiq servers 2016-10-06 10:50:03 +02:00
json_web_token
disable_email_interceptor_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
event_filter_spec.rb Fix inconsistent highlighting of already selected activity nav-links 2016-10-05 15:38:18 -05:00
expand_variables_spec.rb Verify expandability of variables defined as part of environment 2016-09-19 10:07:13 +02:00
extracts_path_spec.rb Add failing test for #21334 2016-08-24 02:18:38 +02:00
file_size_validator_spec.rb
git_ref_validator_spec.rb
gitlab_spec.rb Update `Gitlab.com?` to support staging 2016-06-27 15:10:36 -04:00
repository_cache_spec.rb Use project ID in repository cache to prevent stale data from persisting across projects 2016-07-25 05:09:28 -07:00