6d37fe952b
Fix missing access checks on issue lookup using IssuableFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ⚠️ - Potentially untested 💣 - No test coverage 🚥 - Test coverage of some sort exists (a test failed when error raised) 🚦 - Test coverage of return value (a test failed when nil used) ✅ - Permissions check tested - [x] ✅ app/controllers/projects/branches_controller.rb:39 - `before_action :authorize_push_code!` helpes limit/prevent exploitation. Always checks for reporter access so fine with confidential issues, issues only visible to team, etc. - [x] 🚥 app/models/cycle_analytics/summary.rb:9 [`.count`] - [x] ✅ app/controllers/projects/todos_controller.rb:19 - [x] Potential double render in app/controllers/projects/todos_controller.rb - https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#cedccb227af9bfdf88802767cb58d43c2b977439_24_24 See merge request !2030
48 lines
1.9 KiB
Ruby
48 lines
1.9 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe 'CycleAnalytics#issue', models: true do
|
|
extend CycleAnalyticsHelpers::TestGeneration
|
|
|
|
let(:project) { create(:project) }
|
|
let(:from_date) { 10.days.ago }
|
|
let(:user) { create(:user, :admin) }
|
|
subject { CycleAnalytics.new(project, user, from: from_date) }
|
|
|
|
generate_cycle_analytics_spec(
|
|
phase: :issue,
|
|
data_fn: -> (context) { { issue: context.build(:issue, project: context.project) } },
|
|
start_time_conditions: [["issue created", -> (context, data) { data[:issue].save }]],
|
|
end_time_conditions: [["issue associated with a milestone",
|
|
-> (context, data) do
|
|
if data[:issue].persisted?
|
|
data[:issue].update(milestone: context.create(:milestone, project: context.project))
|
|
end
|
|
end],
|
|
["list label added to issue",
|
|
-> (context, data) do
|
|
if data[:issue].persisted?
|
|
data[:issue].update(label_ids: [context.create(:label, lists: [context.create(:list)]).id])
|
|
end
|
|
end]],
|
|
post_fn: -> (context, data) do
|
|
if data[:issue].persisted?
|
|
context.create_merge_request_closing_issue(data[:issue].reload)
|
|
context.merge_merge_requests_closing_issue(data[:issue])
|
|
end
|
|
end)
|
|
|
|
context "when a regular label (instead of a list label) is added to the issue" do
|
|
it "returns nil" do
|
|
5.times do
|
|
regular_label = create(:label)
|
|
issue = create(:issue, project: project)
|
|
issue.update(label_ids: [regular_label.id])
|
|
|
|
create_merge_request_closing_issue(issue)
|
|
merge_merge_requests_closing_issue(issue)
|
|
end
|
|
|
|
expect(subject.issue).to be_nil
|
|
end
|
|
end
|
|
end
|