3025b71141
By comparing objects in Ruby we can greatly improve the performance of this method. In the worst case (should no data be eager loaded) this will run the same amount of queries as before, in the best case (when data _is_ eager loadeD) it requires no queries at all. The added benchmark used to produce around 273 iterations per second. With this commit this has been increased to almost 40 000 iterations per second: a speedup of roughly 145 times. Combined with eager loading Note associations this results in about 30 queries less when viewing a single issue, this in turn cuts down the loading time by 30-40%.
23 lines
559 B
Ruby
23 lines
559 B
Ruby
require 'spec_helper'
|
|
|
|
describe ProjectTeam, benchmark: true do
|
|
describe '#max_member_access' do
|
|
let(:group) { create(:group) }
|
|
let(:project) { create(:empty_project, group: group) }
|
|
let(:user) { create(:user) }
|
|
|
|
before do
|
|
project.team << [user, :master]
|
|
|
|
5.times do
|
|
project.team << [create(:user), :reporter]
|
|
|
|
project.group.add_user(create(:user), :reporter)
|
|
end
|
|
end
|
|
|
|
benchmark_subject { project.team.max_member_access(user.id) }
|
|
|
|
it { is_expected.to iterate_per_second(35000) }
|
|
end
|
|
end
|