82a39e3e69
Resolve "EmailsOnPushWorker incorrectly claims deleted a commit after a push" ## What does this MR do? Fix the comparison order in the emails on push worker, so regular pushes don't show a message about force pushing. ## Are there points in the code the reviewer needs to double check? Don't think so, it was just a typo: `after_sha` should map to the `source_branch` argument, because it's the head of the comparison. ## Why was this MR needed? To fix a regression! ## What are the relevant issue numbers? Closes #21010. ## Does this MR meet the acceptance criteria? - [x] ~~[CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added~~ - [x] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~ - [x] ~~API support added~~ - Tests - [x] Added for this feature/bug - [ ] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5894 |
||
|---|---|---|
| .. | ||
| repository_check | ||
| build_email_worker_spec.rb | ||
| delete_user_worker_spec.rb | ||
| email_receiver_worker_spec.rb | ||
| emails_on_push_worker_spec.rb | ||
| expire_build_artifacts_worker_spec.rb | ||
| git_garbage_collect_worker_spec.rb | ||
| group_destroy_worker_spec.rb | ||
| merge_worker_spec.rb | ||
| post_receive_spec.rb | ||
| project_cache_worker_spec.rb | ||
| project_destroy_worker_spec.rb | ||
| remove_expired_group_links_worker_spec.rb | ||
| remove_expired_members_worker_spec.rb | ||
| repository_fork_worker_spec.rb | ||
| repository_import_worker_spec.rb | ||
| stuck_ci_builds_worker_spec.rb | ||