86cbef4df4
Add `seconds` unit to latency metrics based on uptream naming convention[0]. [0]: https://prometheus.io/docs/practices/naming/#metric-names
114 lines
3.9 KiB
Ruby
114 lines
3.9 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe MetricsController do
|
|
include StubENV
|
|
|
|
let(:json_response) { JSON.parse(response.body) }
|
|
let(:metrics_multiproc_dir) { Dir.mktmpdir }
|
|
let(:whitelisted_ip) { '127.0.0.1' }
|
|
let(:whitelisted_ip_range) { '10.0.0.0/24' }
|
|
let(:ip_in_whitelisted_range) { '10.0.0.1' }
|
|
let(:not_whitelisted_ip) { '10.0.1.1' }
|
|
|
|
before do
|
|
stub_env('IN_MEMORY_APPLICATION_SETTINGS', 'false')
|
|
stub_env('prometheus_multiproc_dir', metrics_multiproc_dir)
|
|
allow(Gitlab::Metrics).to receive(:prometheus_metrics_enabled?).and_return(true)
|
|
allow(Settings.monitoring).to receive(:ip_whitelist).and_return([whitelisted_ip, whitelisted_ip_range])
|
|
end
|
|
|
|
describe '#index' do
|
|
shared_examples_for 'endpoint providing metrics' do
|
|
it 'returns DB ping metrics' do
|
|
get :index
|
|
|
|
expect(response.body).to match(/^db_ping_timeout 0$/)
|
|
expect(response.body).to match(/^db_ping_success 1$/)
|
|
expect(response.body).to match(/^db_ping_latency_seconds [0-9\.]+$/)
|
|
end
|
|
|
|
it 'returns Redis ping metrics' do
|
|
get :index
|
|
|
|
expect(response.body).to match(/^redis_ping_timeout 0$/)
|
|
expect(response.body).to match(/^redis_ping_success 1$/)
|
|
expect(response.body).to match(/^redis_ping_latency_seconds [0-9\.]+$/)
|
|
end
|
|
|
|
it 'returns Caching ping metrics' do
|
|
get :index
|
|
|
|
expect(response.body).to match(/^redis_cache_ping_timeout 0$/)
|
|
expect(response.body).to match(/^redis_cache_ping_success 1$/)
|
|
expect(response.body).to match(/^redis_cache_ping_latency_seconds [0-9\.]+$/)
|
|
end
|
|
|
|
it 'returns Queues ping metrics' do
|
|
get :index
|
|
|
|
expect(response.body).to match(/^redis_queues_ping_timeout 0$/)
|
|
expect(response.body).to match(/^redis_queues_ping_success 1$/)
|
|
expect(response.body).to match(/^redis_queues_ping_latency_seconds [0-9\.]+$/)
|
|
end
|
|
|
|
it 'returns SharedState ping metrics' do
|
|
get :index
|
|
|
|
expect(response.body).to match(/^redis_shared_state_ping_timeout 0$/)
|
|
expect(response.body).to match(/^redis_shared_state_ping_success 1$/)
|
|
expect(response.body).to match(/^redis_shared_state_ping_latency_seconds [0-9\.]+$/)
|
|
end
|
|
|
|
it 'returns file system check metrics' do
|
|
get :index
|
|
|
|
expect(response.body).to match(/^filesystem_access_latency_seconds{shard="default"} [0-9\.]+$/)
|
|
expect(response.body).to match(/^filesystem_accessible{shard="default"} 1$/)
|
|
expect(response.body).to match(/^filesystem_write_latency_seconds{shard="default"} [0-9\.]+$/)
|
|
expect(response.body).to match(/^filesystem_writable{shard="default"} 1$/)
|
|
expect(response.body).to match(/^filesystem_read_latency_seconds{shard="default"} [0-9\.]+$/)
|
|
expect(response.body).to match(/^filesystem_readable{shard="default"} 1$/)
|
|
end
|
|
|
|
context 'prometheus metrics are disabled' do
|
|
before do
|
|
allow(Gitlab::Metrics).to receive(:prometheus_metrics_enabled?).and_return(false)
|
|
end
|
|
|
|
it 'returns proper response' do
|
|
get :index
|
|
|
|
expect(response.status).to eq(404)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'accessed from whitelisted ip' do
|
|
before do
|
|
allow(Gitlab::RequestContext).to receive(:client_ip).and_return(whitelisted_ip)
|
|
end
|
|
|
|
it_behaves_like 'endpoint providing metrics'
|
|
end
|
|
|
|
context 'accessed from ip in whitelisted range' do
|
|
before do
|
|
allow(Gitlab::RequestContext).to receive(:client_ip).and_return(ip_in_whitelisted_range)
|
|
end
|
|
|
|
it_behaves_like 'endpoint providing metrics'
|
|
end
|
|
|
|
context 'accessed from not whitelisted ip' do
|
|
before do
|
|
allow(Gitlab::RequestContext).to receive(:client_ip).and_return(not_whitelisted_ip)
|
|
end
|
|
|
|
it 'returns proper response' do
|
|
get :index
|
|
|
|
expect(response.status).to eq(404)
|
|
end
|
|
end
|
|
end
|
|
end
|