57b96eb6db
This ensures the open issues/MR count caches are refreshed properly when creating new issues or MRs. This MR also includes a change to the cache keys to ensure all caches are rebuilt on the fly. This particular problem was not caught in the test suite due to a null cache being used, resulting in all calls that would use a cache using the underlying data directly. In production the code would fail because a newly saved record returns an empty hash in #changes meaning checks such as `state_changed? || confidential_changed?` would return false for new rows, thus never updating the counters. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/38061
48 lines
1.1 KiB
Ruby
48 lines
1.1 KiB
Ruby
module Projects
|
|
# Base class for the various service classes that count project data (e.g.
|
|
# issues or forks).
|
|
class CountService
|
|
# The version of the cache format. This should be bumped whenever the
|
|
# underlying logic changes. This removes the need for explicitly flushing
|
|
# all caches.
|
|
VERSION = 1
|
|
|
|
def initialize(project)
|
|
@project = project
|
|
end
|
|
|
|
def relation_for_count
|
|
raise(
|
|
NotImplementedError,
|
|
'"relation_for_count" must be implemented and return an ActiveRecord::Relation'
|
|
)
|
|
end
|
|
|
|
def count
|
|
Rails.cache.fetch(cache_key) { uncached_count }
|
|
end
|
|
|
|
def refresh_cache
|
|
Rails.cache.write(cache_key, uncached_count)
|
|
end
|
|
|
|
def uncached_count
|
|
relation_for_count.count
|
|
end
|
|
|
|
def delete_cache
|
|
Rails.cache.delete(cache_key)
|
|
end
|
|
|
|
def cache_key_name
|
|
raise(
|
|
NotImplementedError,
|
|
'"cache_key_name" must be implemented and return a String'
|
|
)
|
|
end
|
|
|
|
def cache_key
|
|
['projects', 'count_service', VERSION, @project.id, cache_key_name]
|
|
end
|
|
end
|
|
end
|