1b06377812
If a user upgraded to any GitLab 11.x EE version but switched back to CE, it's possible the state of the EE tables are not in the right state for the EE backport migration to work properly. In particular, there were three tables that had trouble: * epics * geo_event_log * vulnerability_feedback The EE backport migration would fail while trying to add foreign key constraints because a key didn't exist in the table. This happens because any EE migration that add or removed columns between v11.0.0 and v11.11.3 are not guaranteed to be applied in an CE installation. The EE backport schema does not individually backport these migrations. We now check if certain columns are present to determine whether the backport migration is in the proper state. CE users are required to upgrade to v11.11.3 EE if they ever installed EE previously before they can go back to v12.x CE. Tested via: ``` git checkout -f v11.0.0-ee bundle exec rake db:reset git checkout .; git checkout -f v11.11.3 bundle exec rake db:migrate git checkout .; git checkout -f v12.0.0 bundle exec rake db:migrate <failure happens> ```
41 lines
1.1 KiB
Ruby
41 lines
1.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'spec_helper'
|
|
|
|
require Rails.root.join('db', 'migrate', '20190402150158_backport_enterprise_schema.rb')
|
|
|
|
describe BackportEnterpriseSchema, :migration, schema: 20190329085614 do
|
|
include MigrationsHelpers
|
|
|
|
def drop_if_exists(table)
|
|
active_record_base.connection.drop_table(table) if active_record_base.connection.table_exists?(table)
|
|
end
|
|
|
|
describe '#up' do
|
|
it 'creates new EE tables' do
|
|
migrate!
|
|
|
|
expect(active_record_base.connection.table_exists?(:epics)).to be true
|
|
expect(active_record_base.connection.table_exists?(:geo_nodes)).to be true
|
|
end
|
|
|
|
context 'missing EE columns' do
|
|
before do
|
|
drop_if_exists(:epics)
|
|
|
|
active_record_base.connection.create_table "epics" do |t|
|
|
t.integer :group_id, null: false, index: true
|
|
t.integer :author_id, null: false, index: true
|
|
end
|
|
end
|
|
|
|
after do
|
|
drop_if_exists(:epics)
|
|
end
|
|
|
|
it 'flags an error' do
|
|
expect { migrate! }.to raise_error(/Your database is missing.*that is present for GitLab EE/)
|
|
end
|
|
end
|
|
end
|
|
end
|