b5042e5301
The NotificationService has to do quite a lot of work to calculate the
recipients for an email. Where possible, we should try to avoid doing this in an
HTTP request, because the mail are sent by Sidekiq anyway, so there's no need to
schedule those emails immediately.
This commit creates a generic Sidekiq worker that uses Global ID to serialise
and deserialise its arguments, then forwards them to the NotificationService.
The NotificationService gains an `#async` method, so you can replace:
notification_service.new_issue(issue, current_user)
With:
notification_service.async.new_issue(issue, current_user)
And have everything else work as normal, except that calculating the recipients
will be done by Sidekiq, which will then schedule further Sidekiq jobs to send
each email.
105 lines
3.3 KiB
Ruby
105 lines
3.3 KiB
Ruby
module Issues
|
|
class UpdateService < Issues::BaseService
|
|
include SpamCheckService
|
|
|
|
def execute(issue)
|
|
handle_move_between_ids(issue)
|
|
filter_spam_check_params
|
|
change_issue_duplicate(issue)
|
|
move_issue_to_new_project(issue) || update(issue)
|
|
end
|
|
|
|
def before_update(issue)
|
|
spam_check(issue, current_user)
|
|
end
|
|
|
|
def handle_changes(issue, options)
|
|
old_associations = options.fetch(:old_associations, {})
|
|
old_labels = old_associations.fetch(:labels, [])
|
|
old_mentioned_users = old_associations.fetch(:mentioned_users, [])
|
|
old_assignees = old_associations.fetch(:assignees, [])
|
|
|
|
if has_changes?(issue, old_labels: old_labels, old_assignees: old_assignees)
|
|
todo_service.mark_pending_todos_as_done(issue, current_user)
|
|
end
|
|
|
|
if issue.previous_changes.include?('title') ||
|
|
issue.previous_changes.include?('description')
|
|
todo_service.update_issue(issue, current_user, old_mentioned_users)
|
|
end
|
|
|
|
if issue.assignees != old_assignees
|
|
create_assignee_note(issue, old_assignees)
|
|
notification_service.async.reassigned_issue(issue, current_user, old_assignees)
|
|
todo_service.reassigned_issue(issue, current_user, old_assignees)
|
|
end
|
|
|
|
if issue.previous_changes.include?('confidential')
|
|
create_confidentiality_note(issue)
|
|
end
|
|
|
|
added_labels = issue.labels - old_labels
|
|
|
|
if added_labels.present?
|
|
notification_service.async.relabeled_issue(issue, added_labels, current_user)
|
|
end
|
|
|
|
added_mentions = issue.mentioned_users - old_mentioned_users
|
|
|
|
if added_mentions.present?
|
|
notification_service.async.new_mentions_in_issue(issue, added_mentions, current_user)
|
|
end
|
|
end
|
|
|
|
def handle_move_between_ids(issue)
|
|
return unless params[:move_between_ids]
|
|
|
|
after_id, before_id = params.delete(:move_between_ids)
|
|
board_group_id = params.delete(:board_group_id)
|
|
|
|
issue_before = get_issue_if_allowed(before_id, board_group_id)
|
|
issue_after = get_issue_if_allowed(after_id, board_group_id)
|
|
|
|
issue.move_between(issue_before, issue_after)
|
|
end
|
|
|
|
def change_issue_duplicate(issue)
|
|
canonical_issue_id = params.delete(:canonical_issue_id)
|
|
canonical_issue = IssuesFinder.new(current_user).find_by(id: canonical_issue_id)
|
|
|
|
if canonical_issue
|
|
Issues::DuplicateService.new(project, current_user).execute(issue, canonical_issue)
|
|
end
|
|
end
|
|
|
|
def move_issue_to_new_project(issue)
|
|
target_project = params.delete(:target_project)
|
|
|
|
return unless target_project &&
|
|
issue.can_move?(current_user, target_project) &&
|
|
target_project != issue.project
|
|
|
|
update(issue)
|
|
Issues::MoveService.new(project, current_user).execute(issue, target_project)
|
|
end
|
|
|
|
private
|
|
|
|
def get_issue_if_allowed(id, board_group_id = nil)
|
|
return unless id
|
|
|
|
issue =
|
|
if board_group_id
|
|
IssuesFinder.new(current_user, group_id: board_group_id, include_subgroups: true).find_by(id: id)
|
|
else
|
|
project.issues.find(id)
|
|
end
|
|
|
|
issue if can?(current_user, :update_issue, issue)
|
|
end
|
|
|
|
def create_confidentiality_note(issue)
|
|
SystemNoteService.change_issue_confidentiality(issue, issue.project, current_user)
|
|
end
|
|
end
|
|
end
|