c1b490d6ef
Gracefully handle SMTP user input errors (e.g. incorrect email addresses) to prevent Sidekiq retries ### What does this MR do? This MR gracefully handles SMTP input errors (e.g. incorrect or invalid e-mail addresses) to prevent these types of exceptions from causing Sidekiq to retry the task. If these specific exceptions occur, they will be logged, and the e-mail will be dropped from the queue. ### Why was this MR needed? If you include an author that has a misspelled e-mail address, Sidekiq will keep sending e-mail to all the recipients even if they have already received the e-mail. The only way to recover is to clear the Sidekiq queue. Note that other exceptions can still be thrown (e.g. `IOError`, `Net::SMTPAuthenticationError`, `Net::SMTPServerBusy`, `Net::SMTPUnknownError`, and `TimeoutError`). If the worker encounters these, Sidekiq should retry the task. ### What are the relevant issue numbers? Closes https://github.com/gitlabhq/gitlabhq/issues/9560 See merge request !1163 |
||
|---|---|---|
| .. | ||
| email_receiver_worker.rb | ||
| emails_on_push_worker.rb | ||
| fork_registration_worker.rb | ||
| gitlab_shell_worker.rb | ||
| irker_worker.rb | ||
| merge_worker.rb | ||
| post_receive.rb | ||
| project_cache_worker.rb | ||
| project_service_worker.rb | ||
| project_web_hook_worker.rb | ||
| repository_archive_worker.rb | ||
| repository_import_worker.rb | ||
| system_hook_worker.rb | ||