78 lines
1.7 KiB
Ruby
78 lines
1.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rubocop_spec_helper'
|
|
require_relative '../../../rubocop/cop/prefer_class_methods_over_module'
|
|
|
|
RSpec.describe RuboCop::Cop::PreferClassMethodsOverModule do
|
|
it 'flags violation when using module ClassMethods and corrects', :aggregate_failures do
|
|
expect_offense(<<~RUBY)
|
|
module Foo
|
|
extend ActiveSupport::Concern
|
|
|
|
module ClassMethods
|
|
^^^^^^^^^^^^^^^^^^^ Do not use module ClassMethods, use class_methods block instead.
|
|
def a_class_method
|
|
end
|
|
end
|
|
end
|
|
RUBY
|
|
|
|
expect_correction(<<~RUBY)
|
|
module Foo
|
|
extend ActiveSupport::Concern
|
|
|
|
class_methods do
|
|
def a_class_method
|
|
end
|
|
end
|
|
end
|
|
RUBY
|
|
end
|
|
|
|
it "doesn't flag violation when using class_methods" do
|
|
expect_no_offenses(<<~RUBY)
|
|
module Foo
|
|
extend ActiveSupport::Concern
|
|
|
|
class_methods do
|
|
def a_class_method
|
|
end
|
|
end
|
|
end
|
|
RUBY
|
|
end
|
|
|
|
it "doesn't flag violation when module is not extending ActiveSupport::Concern" do
|
|
expect_no_offenses(<<~RUBY)
|
|
module Foo
|
|
module ClassMethods
|
|
def a_class_method
|
|
end
|
|
end
|
|
end
|
|
RUBY
|
|
end
|
|
|
|
it "doesn't flag violation when ClassMethods is used inside a class" do
|
|
expect_no_offenses(<<~RUBY)
|
|
class Foo
|
|
module ClassMethods
|
|
def a_class_method
|
|
end
|
|
end
|
|
end
|
|
RUBY
|
|
end
|
|
|
|
it "doesn't flag violation when not using either class_methods or ClassMethods" do
|
|
expect_no_offenses(<<~RUBY)
|
|
module Foo
|
|
extend ActiveSupport::Concern
|
|
|
|
def a_method
|
|
end
|
|
end
|
|
RUBY
|
|
end
|
|
end
|