71672dfa6a
This replaces the use of fake_application_settings with
`::ApplicationSetting.build`_from_defaults. The reason is that
`fake_application_settings` doesn't have the custom accessors that
`ApplicationSetting` has, e.g. `#commit_email_hostname`, thus this
can lead to unexpected `nil` values which comes from the database
column instead of `.default_commit_email_hostname` returned by
`ApplicationSetting#commit_email_hostname`.
Using `::ApplicationSetting.build_from_defaults` should be safe as it
doesn't try to `INSERT` a DB record, in contrary to
`::ApplicationSetting.create_from_defaults` which we used to use, and
which created issues that the introduction of
`fake_application_settings` tried to resolve (
|
||
|---|---|---|
| .. | ||
| api | ||
| assets | ||
| backup | ||
| banzai | ||
| bitbucket | ||
| bitbucket_server | ||
| constraints | ||
| container_registry | ||
| declarative_policy | ||
| flowdock | ||
| generators/rails/post_deployment_migration | ||
| gitaly | ||
| gitlab | ||
| google_api | ||
| haml_lint | ||
| json_web_token | ||
| mattermost | ||
| microsoft_teams | ||
| object_storage | ||
| omni_auth/strategies | ||
| peek | ||
| quality | ||
| rouge | ||
| rspec_flaky | ||
| support | ||
| system_check | ||
| tasks | ||
| after_commit_queue.rb | ||
| backup.rb | ||
| banzai.rb | ||
| carrier_wave_string_file.rb | ||
| declarative_policy.rb | ||
| event_filter.rb | ||
| expand_variables.rb | ||
| extracts_path.rb | ||
| feature.rb | ||
| file_size_validator.rb | ||
| forever.rb | ||
| gitlab.rb | ||
| gt_one_coercion.rb | ||
| milestone_array.rb | ||
| mysql_zero_date.rb | ||
| static_model.rb | ||
| system_check.rb | ||
| unfold_form.rb | ||
| uploaded_file.rb | ||
| version_check.rb | ||