5b0954759c
Fix static-snalysis Move the precedence of group secure variable before project secure variable. Allow project_id to be null. Separate Ci::VariableProject and Ci::VariableGroup Add the forgotton files Add migration file to update type of ci_variables Fix form_for fpr VariableProject Fix test Change the table structure according to the yorik advice Add necessary migration files. Remove unnecessary migration spec. Revert safe_model_attributes.yml Fix models Fix spec Avoid self.variable. Use becomes for correct routing. Use unique index on group_id and key Add null: false for t.timestamps Fix schema version Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable Rename the rest of them Add the rest of files Basic BE change Fix static-snalysis Move the precedence of group secure variable before project secure variable. Allow project_id to be null. Separate Ci::VariableProject and Ci::VariableGroup Add the forgotton files Add migration file to update type of ci_variables Fix form_for fpr VariableProject Fix test Change the table structure according to the yorik advice Add necessary migration files. Remove unnecessary migration spec. Revert safe_model_attributes.yml Fix models Fix spec Avoid self.variable. Use becomes for correct routing. Use unique index on group_id and key Add null: false for t.timestamps Fix schema version Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable Rename the rest of them Add the rest of files Implement CURD Rename codes related to VariableGroup and VariableProject FE part Remove unneccesary changes Make Fe code up-to-date Add protected flag to migration file Protected group variables essential package Update schema Improve doc Fix logic and spec for models Fix logic and spec for controllers Fix logic and spec for views(pre feature) Add feature spec Fixed bugs. placeholder. reveal button. doc. Add changelog Remove unnecessary comment godfat nice catches Improve secret_variables_for arctecture Fix spec Fix StaticAnlysys & path_regex spec Revert "Improve secret_variables_for arctecture" This reverts commit c3216ca212322ecf6ca534cb12ce75811a4e77f1. Use ayufan suggestion for secret_variables_for Use find instead of find_by Fix spec message for variable is invalid Fix spec remove variable.group_id = group.id godffat spec nitpicks Use include Gitlab::Routing.url_helpers for presenter spec
78 lines
2.2 KiB
Ruby
78 lines
2.2 KiB
Ruby
require 'spec_helper'
|
|
|
|
feature 'Group variables', js: true do
|
|
let(:user) { create(:user) }
|
|
let(:group) { create(:group) }
|
|
|
|
background do
|
|
group.add_master(user)
|
|
gitlab_sign_in(user)
|
|
end
|
|
|
|
context 'when user creates a new variable' do
|
|
background do
|
|
visit group_settings_ci_cd_path(group)
|
|
fill_in 'variable_key', with: 'AAA'
|
|
fill_in 'variable_value', with: 'AAA123'
|
|
find(:css, "#variable_protected").set(true)
|
|
click_on 'Add new variable'
|
|
end
|
|
|
|
scenario 'user sees the created variable' do
|
|
page.within('.variables-table') do
|
|
expect(find(".variable-key")).to have_content('AAA')
|
|
expect(find(".variable-value")).to have_content('******')
|
|
expect(find(".variable-protected")).to have_content('Yes')
|
|
end
|
|
click_on 'Reveal Values'
|
|
page.within('.variables-table') do
|
|
expect(find(".variable-value")).to have_content('AAA123')
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when user edits a variable' do
|
|
background do
|
|
create(:ci_group_variable, key: 'AAA', value: 'AAA123', protected: true,
|
|
group: group)
|
|
|
|
visit group_settings_ci_cd_path(group)
|
|
|
|
page.within('.variable-menu') do
|
|
click_on 'Update'
|
|
end
|
|
|
|
fill_in 'variable_key', with: 'BBB'
|
|
fill_in 'variable_value', with: 'BBB123'
|
|
find(:css, "#variable_protected").set(false)
|
|
click_on 'Save variable'
|
|
end
|
|
|
|
scenario 'user sees the updated variable' do
|
|
page.within('.variables-table') do
|
|
expect(find(".variable-key")).to have_content('BBB')
|
|
expect(find(".variable-value")).to have_content('******')
|
|
expect(find(".variable-protected")).to have_content('No')
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when user deletes a variable' do
|
|
background do
|
|
create(:ci_group_variable, key: 'BBB', value: 'BBB123', protected: false,
|
|
group: group)
|
|
|
|
visit group_settings_ci_cd_path(group)
|
|
|
|
page.within('.variable-menu') do
|
|
page.accept_alert 'Are you sure?' do
|
|
click_on 'Remove'
|
|
end
|
|
end
|
|
end
|
|
|
|
scenario 'user does not see the deleted variable' do
|
|
expect(page).to have_no_css('.variables-table')
|
|
end
|
|
end
|
|
end
|