kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/spec/helpers
History
Rémy Coutable 212cf8f950 Merge branch 'rs-optimize-award_user_list-spec' into 'master' 
Optimize the `award_user_list` helper spec

According to
https://gitlab.com/gitlab-org/gitlab-ce/issues/23034#note_16586657, each
test for this helper generated 1,833 queries.

Now we only generate stubbed records, and only as many as we need for
each test.

This also corrects a slight logic bug in the helper itself. When the
number of awards was greater than the limit (9 by default), _and_ the
current user was one of them, we actually included 10 names, including
"You", plus the remaining count. Now we return the correct number
regardless.

See merge request !6722
 		2016-10-07 15:18:22 +00:00
..
application_helper_spec.rb fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
auth_helper_spec.rb
…
blob_helper_spec.rb edit_blob_link can receive the blob to avoid access to the repository 2016-08-18 16:30:25 +02:00
broadcast_messages_helper_spec.rb Enable CacheMarkdownField for the remaining models 2016-10-07 02:54:26 +01:00
ci_status_helper_spec.rb
…
commits_helper_spec.rb
…
diff_helper_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
emails_helper_spec.rb fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
events_helper_spec.rb fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
form_helper_spec.rb
…
git_helper_spec.rb Add more tests for merge request versions feature 2016-09-07 10:22:57 +03:00
gitlab_markdown_helper_spec.rb fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
gitlab_routing_helper_spec.rb
…
graph_helper_spec.rb fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
groups_helper_spec.rb Syntax fixes and better tests for helper methods. Updated docs. 2016-09-15 14:10:49 -05:00
icons_helper_spec.rb
…
import_helper_spec.rb Don't create groups for unallowed users when importing projects 2016-08-31 12:55:45 -03:00
issuables_helper_spec.rb Small improvements thanks to Robert's feedback 2016-09-30 12:02:54 +02:00
issues_helper_spec.rb Optimize the `award_user_list` helper spec 2016-10-07 16:34:58 +02:00
labels_helper_spec.rb
…
members_helper_spec.rb Fix specs that requires an access request 2016-09-22 11:12:17 +02:00
merge_requests_helper_spec.rb
…
milestones_helper_spec.rb Ensure milestone counts work with no data 2016-09-07 15:27:14 -05:00
notes_helper_spec.rb Revert unrelevant changes 2016-08-16 10:00:13 +02:00
notifications_helper_spec.rb
…
page_layout_helper_spec.rb Update Hamlit to 2.6.1 2016-08-18 13:26:32 -05:00
preferences_helper_spec.rb
…
projects_helper_spec.rb Change user & group landing page routing from /u/:name & /groups/:name to /:name 2016-10-06 19:50:48 +03:00
runners_helper_spec.rb
…
search_helper_spec.rb Backport search_helper changes from EE 2016-09-14 14:31:02 +03:00
sidekiq_helper_spec.rb Reformat Regexp 2016-09-08 15:46:22 +02:00
submodule_helper_spec.rb fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
tab_helper_spec.rb
…
time_helper_spec.rb Cleanup the use of duration and optimize some queries 2016-08-10 23:12:02 +08:00
tree_helper_spec.rb fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
visibility_level_helper_spec.rb
…